From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935201AbdCVPkz (ORCPT ); Wed, 22 Mar 2017 11:40:55 -0400 Received: from foss.arm.com ([217.140.101.70]:44288 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759587AbdCVPks (ORCPT ); Wed, 22 Mar 2017 11:40:48 -0400 Date: Wed, 22 Mar 2017 15:32:09 +0000 From: Catalin Marinas To: Arnd Bergmann Cc: Will Deacon , Linux Kernel Mailing List , Linux ARM Subject: Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Message-ID: <20170322153208.GC25645@e104818-lin.cambridge.arm.com> References: <20170314213939.3874497-1-arnd@arndb.de> <20170322143729.GB25645@e104818-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 22, 2017 at 03:51:54PM +0100, Arnd Bergmann wrote: > On Wed, Mar 22, 2017 at 3:37 PM, Catalin Marinas > wrote: > > Hi Arnd, > > > > On Tue, Mar 14, 2017 at 10:39:21PM +0100, Arnd Bergmann wrote: > >> This mirrors commit e9c38ceba8d9 ("ARM: 8455/1: define __BUG as > >> asm(BUG_INSTR) without CONFIG_BUG") to make the behavior of > >> arm64 consistent with arm and x86, and avoids lots of warnings in > >> randconfig builds, such as: > >> > >> kernel/seccomp.c: In function '__seccomp_filter': > >> kernel/seccomp.c:666:1: error: no return statement in function returning non-void [-Werror=return-type] > >> > >> Signed-off-by: Arnd Bergmann > > > > A side-effect of this patch is that it turns WARN into BUG. I hit the > > WARN_ONCE in arch/arm64/kernel/efi.c:34 (on Juno with 64K pages) and > > with your patch applied, the kernel panics. > > Taht was certainly not intended, and I don't see yet what exactly is going on. > What is your setting for CONFIG_BUG and CONFIG_BUGVERBOSE? CONFIG_BUG=y CONFIG_DEBUG_BUGVERBOSE=y (just defconfig + 64K pages) -- Catalin