From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935044AbdCVRNj (ORCPT ); Wed, 22 Mar 2017 13:13:39 -0400 Received: from muru.com ([72.249.23.125]:41286 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759623AbdCVRME (ORCPT ); Wed, 22 Mar 2017 13:12:04 -0400 From: Tony Lindgren To: Mark Brown Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Charles Keepax , Lee Jones , Marcel Partap , Michael Scott Subject: [PATCH 3/4] mfd: cpcap: Use ack_invert interrupts Date: Wed, 22 Mar 2017 10:10:51 -0700 Message-Id: <20170322171052.7006-4-tony@atomide.com> X-Mailer: git-send-email 2.11.1 In-Reply-To: <20170322171052.7006-1-tony@atomide.com> References: <20170322171052.7006-1-tony@atomide.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We should use ack_invert as the int_read_and_clear() in the Motorola kernel tree does "ireg_val & ~mreg_val" before writing to the mask register. Cc: Charles Keepax Cc: Lee Jones Cc: Marcel Partap Cc: Michael Scott Tested-by: Sebastian Reichel Signed-off-by: Tony Lindgren --- drivers/mfd/motorola-cpcap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/motorola-cpcap.c b/drivers/mfd/motorola-cpcap.c --- a/drivers/mfd/motorola-cpcap.c +++ b/drivers/mfd/motorola-cpcap.c @@ -72,6 +72,7 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = { .mask_base = CPCAP_REG_MIM1, .use_ack = true, .handle_reread = true, + .ack_invert = true, }, { .name = "cpcap-m2", @@ -81,6 +82,7 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = { .mask_base = CPCAP_REG_MIM2, .use_ack = true, .handle_reread = true, + .ack_invert = true, }, { .name = "cpcap1-4", @@ -91,6 +93,7 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = { .type_base = CPCAP_REG_INTS1, .use_ack = true, .handle_reread = true, + .ack_invert = true, }, }; -- 2.11.1