From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936128AbdCVTWh (ORCPT ); Wed, 22 Mar 2017 15:22:37 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:47993 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935003AbdCVTWf (ORCPT ); Wed, 22 Mar 2017 15:22:35 -0400 Date: Wed, 22 Mar 2017 20:22:21 +0100 From: Maxime Ripard To: Icenowy Zheng Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 1/3] ARM: sun8i: v3s: add LRADC device node Message-ID: <20170322192221.yhtk6qmzqka4vssd@lukather> References: <20170317154343.39921-1-icenowy@aosc.xyz> <20170317154343.39921-2-icenowy@aosc.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qrs2aqduen5qwjgq" Content-Disposition: inline In-Reply-To: <20170317154343.39921-2-icenowy@aosc.xyz> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qrs2aqduen5qwjgq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 17, 2017 at 11:43:41PM +0800, Icenowy Zheng wrote: > Allwinner V3s features a LRADC like the ones in older SoCs. >=20 > Add a device tree node for it. >=20 > Signed-off-by: Icenowy Zheng > --- > arch/arm/boot/dts/sun8i-v3s.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v= 3s.dtsi > index 71075969e5e6..77bbf5ff9548 100644 > --- a/arch/arm/boot/dts/sun8i-v3s.dtsi > +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi > @@ -238,6 +238,13 @@ > interrupts =3D ; > }; > =20 > + lradc: lradc@01c22800 { The node name should reflect the class of the device, so something like adc= @.. > + compatible =3D "allwinner,sun4i-a10-lradc-keys"; Please put a SoC-specific compatible there. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --qrs2aqduen5qwjgq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJY0s7pAAoJEBx+YmzsjxAgkeoP/0Kq8WF9IG01lQSwCKw88Htr bTxmcuE9qtGMSKzk4omkYQAp6leonfL6hZu0mxRZ80443NJVBfRJm8X0zBnzJBC8 J3lDIqzY8S16kJ8sp7wBgd8gWQSoB6DFRU70121025vjI9w8e3HLgjTQlAbYhi5X DcZnsqIvUYqV/x5WS+5tcSTTItsBsCYS/ffpShPkvOL8jWu0af4bzTxPWdd+pAsu 5rk+klnThJZiiT/do+vh183pDLYHLPfNf1/hHMe9cDlezyFQXzzT74Swgr047Ol/ yw6gly8pTcUUcVIwbO2zbviw5oIeZKADYsbA+mEBX8wMAmgCyjDOZ+sT5f9HjXKI iGkBoKsV21i5b+YaxhE7/9VHTXWr9E1KgFD01KZAaqugv1PdMkRJcce18r434qfJ sQEtXT+px7Rfb/490RX58v1Z9zPmGS1oiLFH1PMQmVHgrTDhHef9JBqAvWou4XqB pVo3oDYaMfwAwtlLMytjhiG7Kj+uv2Xq4XzSJgVqb90DwDQCp7lcGJB+IvM8NfeY K6UM53RZbvalZc38RTbtc3kx/f6fP0IkHJ+08IRhXMmyYcfi0LRp5/QiyrSm0Eq6 ic/RsdmDZ/kMxXFCvqxL70ciYt2PzWLUa6qeCi1hnR0l/DtpdthiDys9KYnsAFFV nvz2lglLWD5fGM5nmBlX =bhex -----END PGP SIGNATURE----- --qrs2aqduen5qwjgq--