From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965948AbdCVTZ4 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 22 Mar 2017 15:25:56 -0400
Received: from mail.skyhub.de ([5.9.137.197]:39244 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S934716AbdCVTYN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 22 Mar 2017 15:24:13 -0400
Date: Wed, 22 Mar 2017 20:22:58 +0100
From: Borislav Petkov <bp@alien8.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: X86 ML <x86@kernel.org>, linux-edac <linux-edac@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] RAS: Add a Corrected Errors Collector
Message-ID: <20170322192258.GC20697@nazgul.tnic>
References: <20170309100818.15466-1-bp@alien8.de>
 <20170309100818.15466-4-bp@alien8.de>
 <20170322190024.GA3073@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20170322190024.GA3073@intel.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 22, 2017 at 12:00:25PM -0700, Luck, Tony wrote:
> You also need to check that bit 61 of m->status is zero here.
> The collector is hiding uncorrected errors too.

Good catch.

I think I wanna do something like this:

	if (memory_error(m) && !(m->status & MCI_STATUS_UC) ...

as we want to make sure we're looking at a memory error first and then
decide on severity.

Alternatively I could stick that logic in another helper called
correctable_memory_error() or so but I don't have a strong preference.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--