From: David Miller <davem@davemloft.net>
To: martin.petersen@oracle.com
Cc: QLogic-Storage-Upstream@cavium.com, jejb@linux.vnet.ibm.com,
arnd@arndb.de, Ram.Amrani@cavium.com, Chad.Dupuis@cavium.com,
Tomer.Tayar@cavium.com, Yuval.Mintz@cavium.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] qedf: fix wrong le16 conversion
Date: Thu, 23 Mar 2017 11:56:30 -0700 (PDT) [thread overview]
Message-ID: <20170323.115630.1600544123792478571.davem@davemloft.net> (raw)
In-Reply-To: <yq1r31odqjs.fsf@oracle.com>
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Date: Thu, 23 Mar 2017 10:19:03 -0400
> Arnd Bergmann <arnd@arndb.de> writes:
>
>> gcc points out that we are converting a 16-bit integer into a 32-bit
>> little-endian type and assigning that to 16-bit little-endian
>> will end up with a zero:
>>
>> drivers/scsi/qedf/drv_fcoe_fw_funcs.c: In function 'init_initiator_rw_fcoe_task':
>> include/uapi/linux/byteorder/big_endian.h:32:26: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
>> t_st_ctx->read_write.rx_id = cpu_to_le32(FCOE_RX_ID);
>>
>> The correct solution appears to be to just use a 16-bit byte swap instead.
>>
>> Fixes: be086e7c53f1 ("qed*: Utilize Firmware 8.15.3.0")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> drivers/scsi/qedf/drv_fcoe_fw_funcs.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Dave: Since you queued the firmware patch, mind taking this fix through
> your tree?
Ok, applied to net-next, thanks.
next prev parent reply other threads:[~2017-03-23 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 8:49 Arnd Bergmann
2017-03-20 13:40 ` Chad Dupuis
2017-03-23 14:19 ` Martin K. Petersen
2017-03-23 18:56 ` David Miller [this message]
2017-03-23 20:07 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323.115630.1600544123792478571.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Chad.Dupuis@cavium.com \
--cc=QLogic-Storage-Upstream@cavium.com \
--cc=Ram.Amrani@cavium.com \
--cc=Tomer.Tayar@cavium.com \
--cc=Yuval.Mintz@cavium.com \
--cc=arnd@arndb.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®