From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751461AbdCWHo4 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 23 Mar 2017 03:44:56 -0400
Received: from bombadil.infradead.org ([65.50.211.133]:35504 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751191AbdCWHox (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 23 Mar 2017 03:44:53 -0400
Date: Thu, 23 Mar 2017 08:42:01 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@kernel.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Mike Galbraith <efault@gmx.de>, Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: Prefer sibiling only if local group is
 under-utilized
Message-ID: <20170323074201.qufsm2h6hvndrfdy@hirez.programming.kicks-ass.net>
References: <1490205470-10249-1-git-send-email-srikar@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1490205470-10249-1-git-send-email-srikar@linux.vnet.ibm.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 22, 2017 at 11:27:50PM +0530, Srikar Dronamraju wrote:

> @@ -7536,8 +7537,8 @@ static inline void update_sd_lb_stats(struct lb_env *env, struct sd_lb_stats *sd
>  		 * the tasks on the system).
>  		 */
>  		if (prefer_sibling && sds->local &&
> -		    group_has_capacity(env, &sds->local_stat) &&
> -		    (sgs->sum_nr_running > 1)) {
> +		    group_has_capacity(env, local) &&
> +		    (sgs->sum_nr_running > local->sum_nr_running + 1)) {
>  			sgs->group_no_capacity = 1;
>  			sgs->group_type = group_classify(sg, sgs);
>  		}

Ah, yes that makes sense!

Thanks