From: Mark Stenglein <mark@stengle.in>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Mark Stenglein <mark@stengle.in>
Subject: [PATCH] staging: most: Adds parentheses around macros with complex values
Date: Thu, 23 Mar 2017 04:38:38 -0400 [thread overview]
Message-ID: <20170323083838.29565-1-mark@stengle.in> (raw)
Fixes three instances of the following checklist error:
- ERROR: Macros with complex values should be enclosed
in parentheses
Simply adds parentheses around the macros to fix the problem.
Signed-off-by: Mark Stenglein <mark@stengle.in>
---
drivers/staging/most/mostcore/core.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c
index 191404bc5906..13e65f149d68 100644
--- a/drivers/staging/most/mostcore/core.c
+++ b/drivers/staging/most/mostcore/core.c
@@ -341,8 +341,8 @@ static ssize_t show_channel_starving(struct most_c_obj *c,
return snprintf(buf, PAGE_SIZE, "%d\n", c->is_starving);
}
-#define create_show_channel_attribute(val) \
- static MOST_CHNL_ATTR(val, 0444, show_##val, NULL)
+#define(create_show_channel_attribute(val) \
+ static MOST_CHNL_ATTR(val, 0444, show_##val, NULL))
create_show_channel_attribute(available_directions);
create_show_channel_attribute(available_datatypes);
@@ -493,8 +493,8 @@ static ssize_t store_set_packets_per_xact(struct most_c_obj *c,
return count;
}
-#define create_channel_attribute(value) \
- static MOST_CHNL_ATTR(value, 0644, show_##value, store_##value)
+#define(create_channel_attribute(value) \
+ static MOST_CHNL_ATTR(value, 0644, show_##value, store_##value))
create_channel_attribute(set_buffer_size);
create_channel_attribute(set_number_of_buffers);
@@ -687,8 +687,8 @@ static ssize_t show_interface(struct most_inst_obj *instance_obj,
return snprintf(buf, PAGE_SIZE, "unknown\n");
}
-#define create_inst_attribute(value) \
- static MOST_INST_ATTR(value, 0444, show_##value, NULL)
+#define(create_inst_attribute(value) \
+ static MOST_INST_ATTR(value, 0444, show_##value, NULL))
create_inst_attribute(description);
create_inst_attribute(interface);
--
2.12.1
next reply other threads:[~2017-03-23 8:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 8:38 Mark Stenglein [this message]
2017-03-23 8:59 ` Greg KH
2017-03-25 7:26 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323083838.29565-1-mark@stengle.in \
--to=mark@stengle.in \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®