From: Tony Lindgren <tony@atomide.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>, Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies
Date: Thu, 23 Mar 2017 07:52:15 -0700 [thread overview]
Message-ID: <20170323145215.GK10760@atomide.com> (raw)
In-Reply-To: <20170323010005.xc3phqrimdcrbti4@earth>
* Sebastian Reichel <sre@kernel.org> [170322 18:02]:
> Hi,
>
> On Wed, Mar 22, 2017 at 08:57:16AM -0700, Tony Lindgren wrote:
> > * Pavel Machek <pavel@ucw.cz> [170322 02:29]:
> > > On Wed 2017-03-22 01:09:11, Sebastian Reichel wrote:
> > > > This fixes compilation for files, that try to include the
> > > > cpcap header in alphabetically sorted #include lists.
> > > >
> > > > Signed-off-by: Sebastian Reichel <sre@kernel.org>
> > >
> > > Acked-by: Pavel Machek <pavel@ucw.cz>
> >
> > Hmm I wonder why I never ran into this so far. No objections
> > to the patch though if it fixes the issue with all the necessary
> > headers included.
>
> Because you usually sort includes differently moving headers
> from linux/subdir/XYZ after linux/XYZ. That way regmap.h and
> device.h will already be included when the compiler includes
> motorola-cpcap.h.
Ah OK yeah I do that usually. Your patch seems OK to me:
Acked-by: Tony Lindgren <tony@atomide.com>
prev parent reply other threads:[~2017-03-23 14:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 0:09 Sebastian Reichel
2017-03-22 0:09 ` [PATCHv2 2/2] leds: cpcap: new driver Sebastian Reichel
2017-03-22 20:24 ` Jacek Anaszewski
2017-03-23 1:04 ` Sebastian Reichel
2017-03-22 9:27 ` [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Pavel Machek
2017-03-22 15:57 ` Tony Lindgren
2017-03-23 1:00 ` Sebastian Reichel
2017-03-23 14:52 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323145215.GK10760@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome