From: Lee Jones <lee.jones@linaro.org>
To: Jeremy Linton <lintonrjeremy@gmail.com>
Cc: linux-kernel@vger.kernel.org, broonie@kernel.org,
lgirdwood@gmail.com, puck.chen@hisilicon.com
Subject: Re: [PATCH 1/2] mfd: hi655x: Reference required regulator driver
Date: Thu, 23 Mar 2017 16:31:05 +0000 [thread overview]
Message-ID: <20170323163105.gowbe7p45uak7cyd@dell> (raw)
In-Reply-To: <20170321045341.4833-2-lintonrjeremy@gmail.com>
On Mon, 20 Mar 2017, Jeremy Linton wrote:
> The hisi pmic requires an independent regulator driver to be
> loaded so that devices dependent on the pmic/regulator are
> started properly. Currently there is only a single compatible
> regulator driver in the tree, so reference it with a module soft
> dependency so that modprobe loads it whenever the hisi pmic
> driver is loaded.
This is a new one on my, but it sounds okay.
OOI, what happens when there are lots of compatible drivers?
> Signed-off-by: Jeremy Linton <lintonrjeremy@gmail.com>
> ---
> drivers/mfd/hi655x-pmic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
> index ba706ad..56e027d 100644
> --- a/drivers/mfd/hi655x-pmic.c
> +++ b/drivers/mfd/hi655x-pmic.c
> @@ -184,3 +184,4 @@ module_platform_driver(hi655x_pmic_driver);
> MODULE_AUTHOR("Chen Feng <puck.chen@hisilicon.com>");
> MODULE_DESCRIPTION("Hisilicon hi655x PMIC driver");
> MODULE_LICENSE("GPL v2");
> +MODULE_SOFTDEP("post: hi655x-regulator");
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-03-23 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 4:53 [PATCH 0/2] Hi655x: mfd/pmic: regulator: Correct dependencies Jeremy Linton
2017-03-21 4:53 ` [PATCH 1/2] mfd: hi655x: Reference required regulator driver Jeremy Linton
2017-03-23 16:31 ` Lee Jones [this message]
2017-03-21 4:53 ` [PATCH 2/2] regulator: hi655x: Bump parent pmic module use count Jeremy Linton
2017-03-21 11:08 ` Mark Brown
2017-03-21 20:23 ` Jeremy Linton
2017-03-22 11:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323163105.gowbe7p45uak7cyd@dell \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=lintonrjeremy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=puck.chen@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®