From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755225AbdCXHWP (ORCPT ); Fri, 24 Mar 2017 03:22:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:59649 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751406AbdCXHWH (ORCPT ); Fri, 24 Mar 2017 03:22:07 -0400 Date: Fri, 24 Mar 2017 08:22:03 +0100 From: Michal Hocko To: Kristaps Civkulis Cc: akpm@linux-foundation.org, mike.kravetz@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: fix a coding style issue Message-ID: <20170324072203.GA14875@dhcp22.suse.cz> References: <20170323074902.23768-1-kristaps.civkulis@gmail.com> <52c53f8a-ef23-46ce-040b-d63498a7dfa5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52c53f8a-ef23-46ce-040b-d63498a7dfa5@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 23-03-17 10:12:44, Kristaps Civkulis wrote: > Fix a coding style issue. I believe style fixes are worth applying only when part of a larger change which does something useful or where the resulting code is much easier to read. This doesn't seem to be the case here. > Signed-off-by: Kristaps Civkulis > --- > Resend, because it should be only [PATCH] in subject. > --- > mm/hugetlb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 3d0aab9ee80d..4c72c1974c8c 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1916,8 +1916,7 @@ static long __vma_reservation_common(struct hstate *h, > return 0; > else > return 1; > - } > - else > + } else > return ret < 0 ? ret : 0; > } > > -- > 2.12.0 > -- Michal Hocko SUSE Labs