From: Andrew Lunn <andrew@lunn.ch>
To: Ralph Sennhauser <ralph.sennhauser@gmail.com>
Cc: linux-gpio@vger.kernel.org, Imre Kaloz <kaloz@openwrt.org>,
Thierry Reding <thierry.reding@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jason Cooper <jason@lakedaemon.net>,
Gregory Clement <gregory.clement@free-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/4] gpio: mvebu: Add limited PWM support
Date: Fri, 24 Mar 2017 15:28:54 +0100 [thread overview]
Message-ID: <20170324142854.GJ28518@lunn.ch> (raw)
In-Reply-To: <20170324141815.7252-2-ralph.sennhauser@gmail.com>
> + if (val < state->duty_cycle)
> + state->period = 1;
> + else {
> + val -= state->duty_cycle;
> + if (val > UINT_MAX)
> + state->period = UINT_MAX;
> + else if (val)
> + state->period = val;
> + else
> + state->period = 1;
> + }
Hi Ralph
The coding style guide says that if one side of an if else clause has
{}, the other side must as well, even if it is a single statement.
Andrew
next prev parent reply other threads:[~2017-03-24 15:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 14:18 [PATCH v3 0/4] gpio: mvebu: Add PWM fan support Ralph Sennhauser
2017-03-24 14:18 ` [PATCH v3 1/4] gpio: mvebu: Add limited PWM support Ralph Sennhauser
2017-03-24 14:23 ` Andrew Lunn
2017-03-24 14:28 ` Andrew Lunn [this message]
2017-03-24 14:18 ` [PATCH v3 2/4] mvebu: xp: Add PWM properties to .dtsi files Ralph Sennhauser
2017-03-24 14:18 ` [PATCH v3 3/4] ARM: mvebu: Enable SENSORS_PWM_FAN in defconfig Ralph Sennhauser
2017-03-24 14:18 ` [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan Ralph Sennhauser
2017-03-24 14:35 ` Andrew Lunn
2017-03-24 22:23 ` Ralph Sennhauser
2017-03-26 21:05 ` Ralph Sennhauser
2017-03-27 13:17 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324142854.GJ28518@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=kaloz@openwrt.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=ralph.sennhauser@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome