From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751413AbdCZDOH (ORCPT <rfc822;w@1wt.eu>);
        Sat, 25 Mar 2017 23:14:07 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:60054 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751263AbdCZDOG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 25 Mar 2017 23:14:06 -0400
Date: Sat, 25 Mar 2017 20:05:46 -0700 (PDT)
Message-Id: <20170325.200546.249222967254161798.davem@davemloft.net>
To: arnd@arndb.de
Cc: dledford@redhat.com, oulijun@huawei.com, xavier.huwei@huawei.com,
        huangdaode@hisilicon.com, yankejian@huawei.com, xieqianqian@huawei.com,
        weiyongjun1@huawei.com, yisen.zhuang@huawei.com,
        salil.mehta@huawei.com, sean.hefty@intel.com, hal.rosenstock@gmail.com,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [RESEND PATCH 1/3] net: hns: fix uninitialized data use
From: David Miller <davem@davemloft.net>
In-Reply-To: <20170324220250.2193128-3-arnd@arndb.de>
References: <20170324220250.2193128-1-arnd@arndb.de>
        <20170324220250.2193128-3-arnd@arndb.de>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 25 Mar 2017 20:05:47 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 24 Mar 2017 23:02:49 +0100

> When dev_dbg() is enabled, we print uninitialized data, as gcc-7.0.1
> now points out:
> 
> ethernet/hisilicon/hns/hns_dsaf_main.c: In function 'hns_dsaf_set_promisc_tcam':
> ethernet/hisilicon/hns/hns_dsaf_main.c:2947:75: error: 'tbl_tcam_data.low.val' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> ethernet/hisilicon/hns/hns_dsaf_main.c:2947:75: error: 'tbl_tcam_data.high.val' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> We also pass the data into hns_dsaf_tcam_mc_cfg(), which might later
> use it (not sure about that), so it seems safer to just always initialize
> the tbl_tcam_data structure.
> 
> Fixes: 1f5fa2dd1cfa ("net: hns: fix for promisc mode in HNS driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied.