From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-kernel@vger.kernel.org, kernel-team@lge.com
Subject: Re: [PATCH 4/4] zram: make deduplication feature optional
Date: Mon, 27 Mar 2017 17:11:05 +0900 [thread overview]
Message-ID: <20170327081105.GA390@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20170323030530.GC17486@js1304-P5Q-DELUXE>
On (03/23/17 12:05), Joonsoo Kim wrote:
> On Wed, Mar 22, 2017 at 09:00:59AM +0900, Minchan Kim wrote:
> > On Thu, Mar 16, 2017 at 11:46:38AM +0900, js1304@gmail.com wrote:
> > > From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> > >
> > > Benefit of deduplication is dependent on the workload so it's not
> > > preferable to always enable. Therefore, make it optional.
> >
> > Please make it to Kconfig, too. And write down the description to impress
> > "help a lot for users who uses zram to build output directory"
> > And the feature should be disabled as default.
>
> Okay.
so I was thinking for a moment -- do we want to keep this
functionality in zram or may be it belongs to allocator (zsmalloc)?
what do you think? just a question.
-ss
next prev parent reply other threads:[~2017-03-27 8:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 2:46 [PATCH 0/4] zram: implement deduplication in zram js1304
2017-03-16 2:46 ` [PATCH 1/4] mm/zsmalloc: always set movable/highmem flag to the zspage js1304
2017-03-21 11:10 ` Minchan Kim
2017-03-23 2:10 ` Joonsoo Kim
2017-03-24 0:34 ` Minchan Kim
2017-03-16 2:46 ` [PATCH 2/4] zram: introduce zram_entry to prepare dedup functionality js1304
2017-03-16 2:46 ` [PATCH 3/4] zram: implement deduplication in zram js1304
2017-03-21 23:41 ` Minchan Kim
2017-03-23 3:04 ` Joonsoo Kim
2017-03-24 0:38 ` Minchan Kim
2017-03-23 13:40 ` Sergey Senozhatsky
2017-03-28 0:28 ` Joonsoo Kim
2017-03-16 2:46 ` [PATCH 4/4] zram: make deduplication feature optional js1304
2017-03-22 0:00 ` Minchan Kim
2017-03-23 3:05 ` Joonsoo Kim
2017-03-27 8:11 ` Sergey Senozhatsky [this message]
2017-03-28 1:02 ` Joonsoo Kim
2017-03-28 2:22 ` Sergey Senozhatsky
2017-03-28 2:50 ` Minchan Kim
2017-03-28 5:12 ` Sergey Senozhatsky
2017-03-28 5:57 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327081105.GA390@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®