From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752527AbdC0KPW (ORCPT ); Mon, 27 Mar 2017 06:15:22 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:4797 "EHLO dggrg01-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752147AbdC0KPG (ORCPT ); Mon, 27 Mar 2017 06:15:06 -0400 From: Chao Yu To: CC: , , , Chao Yu Subject: [PATCH 3/3] f2fs: prevent waiter encountering incorrect discard states Date: Mon, 27 Mar 2017 18:14:06 +0800 Message-ID: <20170327101406.56028-3-yuchao0@huawei.com> X-Mailer: git-send-email 2.8.2.295.g3f1c1d0 In-Reply-To: <20170327101406.56028-1-yuchao0@huawei.com> References: <20170327101406.56028-1-yuchao0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.120.216.130] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.58D8E5FC.013D,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 43fac8247558e373da6c4ad133ce5ab3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In f2fs_submit_discard_endio, we will wake up waiter before setting discard command states, so waiter may use incorrect states. Change the order between complete() and states setting to fix this issue. Signed-off-by: Chao Yu --- fs/f2fs/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 57a81f9c8c14..9f9542c9fe47 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -717,9 +717,9 @@ static void f2fs_submit_discard_endio(struct bio *bio) { struct discard_cmd *dc = (struct discard_cmd *)bio->bi_private; - complete(&dc->wait); dc->error = bio->bi_error; dc->state = D_DONE; + complete(&dc->wait); bio_put(bio); } -- 2.8.2.295.g3f1c1d0