From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752777AbdC0Mm2 (ORCPT ); Mon, 27 Mar 2017 08:42:28 -0400 Received: from mail-wr0-f177.google.com ([209.85.128.177]:34732 "EHLO mail-wr0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752257AbdC0MmL (ORCPT ); Mon, 27 Mar 2017 08:42:11 -0400 Date: Mon, 27 Mar 2017 13:41:53 +0100 From: Lee Jones To: Belen Sarabia Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mfd: ipaq-micro: Delete redundant return value check of platform_get_resource() Message-ID: <20170327124153.i2yjadkn4sdqsclh@dell> References: <20170325182647.GA2934@belen-VirtualBox> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170325182647.GA2934@belen-VirtualBox> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 25 Mar 2017, Belen Sarabia wrote: > devm_ioremap_resource does checks on the resource. No need to > duplicate this in the driver. > > Signed-off-by: Belén Sarabia > --- > Changes in v2: > - Subject line expected by the subsystem. > - Remove one line more. > --- > drivers/mfd/ipaq-micro.c | 3 --- > 1 file changed, 3 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c > index df16fd1..124aad2 100644 > --- a/drivers/mfd/ipaq-micro.c > +++ b/drivers/mfd/ipaq-micro.c > @@ -400,9 +400,6 @@ static int __init micro_probe(struct platform_device *pdev) > micro->dev = &pdev->dev; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) > - return -EINVAL; > - > micro->base = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(micro->base)) > return PTR_ERR(micro->base); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog