From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752651AbdC0NQH (ORCPT ); Mon, 27 Mar 2017 09:16:07 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:35929 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059AbdC0NP7 (ORCPT ); Mon, 27 Mar 2017 09:15:59 -0400 Date: Mon, 27 Mar 2017 15:15:30 +0200 From: Alexandre Belloni To: Boris Brezillon Cc: Claudiu Beznea , thierry.reding@gmail.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nicolas.ferre@microchip.com, cristian.birsan@microchip.com, andrei.pistirica@microchip.com, tudor.ambarus@microchip.com, eugen.hristev@microchip.com Subject: Re: [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM Message-ID: <20170327131530.ifexyrgrp5egtbtr@piout.net> References: <1490189375-20384-1-git-send-email-claudiu.beznea@microchip.com> <1490189375-20384-2-git-send-email-claudiu.beznea@microchip.com> <20170327150237.69d8523f@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170327150237.69d8523f@bbrezillon> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/03/2017 at 15:02:37 +0200, Boris Brezillon wrote: > Hi Claudiu, > > On Wed, 22 Mar 2017 15:29:34 +0200 > Claudiu Beznea wrote: > > > static const struct platform_device_id atmel_pwm_devtypes[] = { > > { > > .name = "at91sam9rl-pwm", > > - .driver_data = (kernel_ulong_t)&atmel_pwm_data_v1, > > + .driver_data = (kernel_ulong_t)&atmel_pwm_regs_v1, > > }, { > > .name = "sama5d3-pwm", > > - .driver_data = (kernel_ulong_t)&atmel_pwm_data_v2, > > + .driver_data = (kernel_ulong_t)&atmel_pwm_regs_v2, > > }, { > > /* sentinel */ > > }, > > Unrelated to this series, but can you prepare a patch to get rid of > this platform id table (AT91 platforms have completely switched to DT > for quite some time now). > Please, don't until AVR32 is gone. > You can also get rid of the "if (pdev->dev.of_node)" condition in > atmel_pwm_probe() since it's guaranteed to be true, otherwise the > ->probe() method wouldn't be called. > > Thanks, > > Boris -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com