From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753239AbdC0N6m (ORCPT ); Mon, 27 Mar 2017 09:58:42 -0400 Received: from merlin.infradead.org ([205.233.59.134]:56082 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752825AbdC0N6K (ORCPT ); Mon, 27 Mar 2017 09:58:10 -0400 Date: Mon, 27 Mar 2017 15:58:05 +0200 From: Peter Zijlstra To: Viresh Kumar Cc: Ingo Molnar , linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, Vincent Guittot Subject: Re: [PATCH 0/4] sched: Minor cleanups Message-ID: <20170327135805.t3pnkomktsm4j2vw@hirez.programming.kicks-ass.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 23, 2017 at 05:05:55PM +0530, Viresh Kumar wrote: > Hi, > > Here are few minor cleanups for the sched core. The first three tries to > avoid reinitializing memory which is already set to zero and the last > one drops an unused statement. > I'm OK with the kzalloc/memset thing, but I'd prefer to keep all those other bits. Yes they're superfluous, but this is init code, so nobody cares about performance and having those things explitic makes it easier to read. As to the very latest patch, that's there so that if/when we extend that array we can simply continue. Also its more symmetric/consistent. Any half sane DCE pass should get rid of it anyway, as the result is unused.