From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753725AbdC0OZa (ORCPT ); Mon, 27 Mar 2017 10:25:30 -0400 Received: from mail.kernel.org ([198.145.29.136]:34536 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753574AbdC0OZT (ORCPT ); Mon, 27 Mar 2017 10:25:19 -0400 Date: Mon, 27 Mar 2017 16:24:43 +0200 From: Sebastian Reichel To: Tony Lindgren Cc: Alessandro Zummo , Alexandre Belloni , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: cpcap: fix improper use of IRQ_NONE for request_threaded_irq Message-ID: <20170327142443.zkaiieehqeirk4pi@earth> References: <20170327033423.4536-1-tony@atomide.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jpup43qwdneg7hvx" Content-Disposition: inline In-Reply-To: <20170327033423.4536-1-tony@atomide.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jpup43qwdneg7hvx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sun, Mar 26, 2017 at 08:34:23PM -0700, Tony Lindgren wrote: > There's a funny typo where IRQ_NONE is used instead of IRQF_TRIGGER_NONE > for request_threaded_irq(). Let's fix it before it gets copied elsewhere. >=20 > Fixes: dd3bf50b35e3 ("rtc: cpcap: new rtc driver") > Cc: Sebastian Reichel > Signed-off-by: Tony Lindgren Reviewed-By: Sebastian Reichel -- Sebastian > --- > drivers/rtc/rtc-cpcap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c > --- a/drivers/rtc/rtc-cpcap.c > +++ b/drivers/rtc/rtc-cpcap.c > @@ -275,7 +275,7 @@ static int cpcap_rtc_probe(struct platform_device *pd= ev) > =20 > rtc->alarm_irq =3D platform_get_irq(pdev, 0); > err =3D devm_request_threaded_irq(dev, rtc->alarm_irq, NULL, > - cpcap_rtc_alarm_irq, IRQ_NONE, > + cpcap_rtc_alarm_irq, IRQF_TRIGGER_NONE, > "rtc_alarm", rtc); > if (err) { > dev_err(dev, "Could not request alarm irq: %d\n", err); > @@ -291,7 +291,7 @@ static int cpcap_rtc_probe(struct platform_device *pd= ev) > */ > rtc->update_irq =3D platform_get_irq(pdev, 1); > err =3D devm_request_threaded_irq(dev, rtc->update_irq, NULL, > - cpcap_rtc_update_irq, IRQ_NONE, > + cpcap_rtc_update_irq, IRQF_TRIGGER_NONE, > "rtc_1hz", rtc); > if (err) { > dev_err(dev, "Could not request update irq: %d\n", err); > --=20 > 2.12.1 --jpup43qwdneg7hvx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAljZIKgACgkQ2O7X88g7 +prQjA//SNVOu2zJaIhxg8dL9d/lZBDrhHZuw5kTJvJ4B9XyaP7tvEplhuHAy+NY XaVnyDAhMl5FlfTI3PjujI8qpuV+S3tP2zVcH5yRDdsfNMS6rPqUMwt7ClVzYCg2 GJ6UmdeYBFNF/UhcL3WTFK62Gbzd62RRw04Y33UE4S5vBwIJIVienKXVo8230CvY IzalWHspIyJd+kP/ec86T3Oiws9LC2847QWQXAajyrYCO65rDBFCJhLq6jOhhfxw NWY9JUbM3ksStM3QjHv1ZyPtJsJ9/qiRvv4IoQlWUEfRWtdfJwzI99SVH3BtUWPB Nye6XIrOgquTPlNMI2+2AxQDEs2CAPDKum4xe8+IcP2meB6p5a6P09J1/ajb/Eid +QLHBN0jg8WoNN/ITJ6PgfSWxpMdLkMQ6wLXiVT1MJEmHBLdeL66EvWPLkp7U+ml hAdFpbad/lTL4ZoILr/A2uluXO4iqJAmv4b+UCKHdi2k+5DLKybvgBMlwhDw+b+J 9GKUBTvKsKF9hv2okBU29ZmJeOanh7JBPhkgbzEtjfJW7cX/e3ThXFYh5aPV7QHu F8XE5QBI9d18Ha3AXAEw/YsFSyTo1DdsUB98cBnJp2a/szJDgu2vWPFmQgBfCP/z w31Ca9/VbE7G1dO8zXPRESDrJmA2qNfPwfJixdlucYqowejoxAg= =yjr5 -----END PGP SIGNATURE----- --jpup43qwdneg7hvx--