From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752579AbdC0VYG (ORCPT ); Mon, 27 Mar 2017 17:24:06 -0400 Received: from mail-pg0-f52.google.com ([74.125.83.52]:35179 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751629AbdC0VX7 (ORCPT ); Mon, 27 Mar 2017 17:23:59 -0400 From: Matthias Kaehlcke To: Liam Girdwood , Mark Brown , Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Douglas Anderson , Brian Norris , Matthias Kaehlcke Subject: [PATCH v2] regulator: core: Limit propagation of parent voltage count and list Date: Mon, 27 Mar 2017 14:22:47 -0700 Message-Id: <20170327212247.92317-1-mka@chromium.org> X-Mailer: git-send-email 2.12.2.564.g063fe858b8-goog Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Change 26988efe11b1 ("regulator: core: Allow to get voltage count and list from parent") introduces the propagation of the parent voltage count and list for regulators that don't provide this information themselves. The goal is to support simple switch regulators, however as a side effect normal continuous regulators can leak details of their supplies and provide consumers with inconsistent information. Limit the propagation of the voltage count and list to switch regulators. Signed-off-by: Matthias Kaehlcke --- Changes in v2: - Added flag 'is_switch' that indicates if regulator is a switch - Reworked conditions checking for switch to evaluate the new flag drivers/regulator/core.c | 11 +++++++++-- include/linux/regulator/driver.h | 2 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 53d4fc70dbd0..c81b4f608559 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2486,7 +2486,7 @@ static int _regulator_list_voltage(struct regulator *regulator, ret = ops->list_voltage(rdev, selector); if (lock) mutex_unlock(&rdev->mutex); - } else if (rdev->supply) { + } else if (rdev->is_switch && rdev->supply) { ret = _regulator_list_voltage(rdev->supply, selector, lock); } else { return -EINVAL; @@ -2540,11 +2540,12 @@ EXPORT_SYMBOL_GPL(regulator_is_enabled); int regulator_count_voltages(struct regulator *regulator) { struct regulator_dev *rdev = regulator->rdev; + const struct regulator_ops *ops = rdev->desc->ops; if (rdev->desc->n_voltages) return rdev->desc->n_voltages; - if (!rdev->supply) + if (!rdev->is_switch || !rdev->supply) return -EINVAL; return regulator_count_voltages(rdev->supply); @@ -4099,6 +4100,12 @@ regulator_register(const struct regulator_desc *regulator_desc, mutex_unlock(®ulator_list_mutex); } + if (!rdev->desc->ops->get_voltage && + !rdev->desc->ops->get_voltage_sel && + !rdev->desc->ops->list_voltage && + !rdev->desc->fixed_uV) + rdev->is_switch = true; + ret = device_register(&rdev->dev); if (ret != 0) { put_device(&rdev->dev); diff --git a/include/linux/regulator/driver.h b/include/linux/regulator/driver.h index dac8e7b16bc6..4cb1c9be6073 100644 --- a/include/linux/regulator/driver.h +++ b/include/linux/regulator/driver.h @@ -429,6 +429,8 @@ struct regulator_dev { struct regulator_enable_gpio *ena_pin; unsigned int ena_gpio_state:1; + unsigned int is_switch:1; + /* time when this regulator was disabled last time */ unsigned long last_off_jiffy; }; -- 2.12.2.564.g063fe858b8-goog