From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752552AbdC2EnB (ORCPT <rfc822;w@1wt.eu>);
        Wed, 29 Mar 2017 00:43:01 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:41486 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750954AbdC2EnA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Mar 2017 00:43:00 -0400
Date: Tue, 28 Mar 2017 21:42:58 -0700 (PDT)
Message-Id: <20170328.214258.1096589839586809714.davem@davemloft.net>
To: arnd@arndb.de
Cc: jiri@resnulli.us, idosch@mellanox.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rocker: fix Wmaybe-uninitialized false-positive
From: David Miller <davem@davemloft.net>
In-Reply-To: <20170328141126.1541994-1-arnd@arndb.de>
References: <20170328141126.1541994-1-arnd@arndb.de>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 28 Mar 2017 21:01:44 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 28 Mar 2017 16:11:18 +0200

> gcc-7 reports a warning that earlier versions did not have:
> 
> drivers/net/ethernet/rocker/rocker_ofdpa.c: In function 'ofdpa_port_stp_update':
> arch/x86/include/asm/string_32.h:79:22: error: '*((void *)&prev_ctrls+4)' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>    *((short *)to + 2) = *((short *)from + 2);
>    ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/rocker/rocker_ofdpa.c:2218:7: note: '*((void *)&prev_ctrls+4)' was declared here
> 
> This is clearly a variation of the warning about 'prev_state' that
> was shut up using uninitialized_var().
> 
> We can slightly simplify the code and get rid of the warning by unconditionally
> saving the prev_state and prev_ctrls variables. The inlined memcpy is not
> particularly expensive here, as it just has to read five bytes from one or
> two cache lines.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thank you.