From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752684AbdC2EuI (ORCPT ); Wed, 29 Mar 2017 00:50:08 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:41576 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469AbdC2EuG (ORCPT ); Wed, 29 Mar 2017 00:50:06 -0400 Date: Tue, 28 Mar 2017 21:49:58 -0700 (PDT) Message-Id: <20170328.214958.1031055485189943869.davem@davemloft.net> To: colin.king@canonical.com Cc: jhansen@vmware.com, aditr@vmware.com, julia.lawall@lip6.fr, stefanha@redhat.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] VSOCK: remove unnecessary ternary operator on return value From: David Miller In-Reply-To: <20170328155424.22873-1-colin.king@canonical.com> References: <20170328155424.22873-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 28 Mar 2017 21:08:45 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Tue, 28 Mar 2017 16:54:24 +0100 > From: Colin Ian King > > Rather than assign the positive errno values to ret and then > checking if it is positive and flip the sign, just set ret to > be the -ve errno value. > > Detected by CoverityScan, CID#986649 ("Logically Dead Code") > > Signed-off-by: Colin Ian King Just return the error directly instead of having this variable. Thanks.