From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755050AbdC1KBg (ORCPT ); Tue, 28 Mar 2017 06:01:36 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:62787 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754373AbdC1KBD (ORCPT ); Tue, 28 Mar 2017 06:01:03 -0400 From: Arnd Bergmann To: Tom Lendacky , Gary Hook , Herbert Xu , "David S. Miller" Cc: Arnd Bergmann , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] crypto: ccp - Mark driver as little-endian only Date: Tue, 28 Mar 2017 11:58:05 +0200 Message-Id: <20170328095814.3734615-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170328095814.3734615-1-arnd@arndb.de> References: <20170328095814.3734615-1-arnd@arndb.de> X-Provags-ID: V03:K0:jdjnzSGHDIsC9yPDUPd+IMoVnrrmABLlUXtG2N0dV8lpdUL0h3Q SYfXsOEejX7Zi9eb24hu5Qw9JBnQp0fhPrV8r9B1qppSqgK4eYUuHwrpBPgCrVhMEDnFL9K 2VfMs4Nj1VGx2+sgIFLpDGqQZsOr61+mFHp422UozV0rCI3onwvCSYBoeksCeAvl+AWHo+M NNFGsi+ay8Zf2OwxD2FJg== X-UI-Out-Filterresults: notjunk:1;V01:K0:jkr8RLpGf8s=:aTVy/g2rEuzd41Cy0qRHG4 RO1LjOo/hi6cr9z3Rte1nqQRBLiBdJ+m5JHMsmAqUz0HWWjqCEjZbaIgf6B0Wq8Y13TCTcdHH SY9vr4DgBp2FFscCh6t0nkC4sZKO6O0YQhXqw1aPcUZSDl315mrQ1oGR8+0/HMNqd8D9yDp13 VLn2fRMcNt/mPVo2SDLzA1IJeUKhWjdh42VVqn6DdQbbNRcY8xGzm9hV+YUHc8vTbDg/k66pf BjMJChwRT9864QaNvT7KrYoJ7/V8j8OWsYbDX3lDF/KJ76aCb+NpUH7RuDq3N2uf9gKt2F5TJ HS55B8wjoTh+kQ9PsIXKgZ1DzPfXziGLvkIUQ2X7cRm32fHD5vbVql6EE+joHlPvM76OOrbtZ 7ZNReZvOkFBUgKxo63sIVRm08BwRg6iaIEZSWB8GffusRIqhPNhMAphlazxQ1gr9mjv6N2SAj 9EktOc8zAhtTcSR0PhtGaJHy+Qi6mPzbbGw34o9olcL2QXe8RnZ64jrTyJLpoSH5RT/V0abO8 dWIWVgCn+PHF0YkFBjFYI+s+2k/WD0whwxaYqdks3WKcqcGGGAwGLJEt2lImejdUX2JaZX5Yi Lah0EIZUSsJnMXEqIykOPQkEqK/w6EigkOx2VTCyHxhrPpJk+ZqDsqyHqXEbL9YRgoCsDjoV+ +Mtn9ExA8ldupzOazbcdDTs2zIZysLOQgIayDOm6LyCObKLu65FXcotCeN4gMJ8g6XZg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver causes a warning when built as big-endian: drivers/crypto/ccp/ccp-dev-v5.c: In function 'ccp5_perform_des3': include/uapi/linux/byteorder/big_endian.h:32:26: error: large integer implicitly truncated to unsigned type [-Werror=overflow] #define __cpu_to_le32(x) ((__force __le32)__swab32((x))) ^ include/linux/byteorder/generic.h:87:21: note: in expansion of macro '__cpu_to_le32' #define cpu_to_le32 __cpu_to_le32 ^~~~~~~~~~~~~ drivers/crypto/ccp/ccp-dev-v5.c:436:28: note: in expansion of macro 'cpu_to_le32' CCP5_CMD_KEY_MEM(&desc) = cpu_to_le32(CCP_MEMTYPE_SB); The warning is correct, doing a 32-bit byte swap on a value that gets assigned into a bit field cannot work, since we would only write zeroes in this case, regardless of the input. In fact, the use of bit fields in hardware defined data structures is not portable to start with, so until all these bit fields get replaced by something else, the driver cannot work on big-endian machines, and I'm adding an annotation here to prevent it from being selected. The CCPv3 code seems to not suffer from this problem, only v5 uses bitfields. Fixes: 4b394a232df7 ("crypto: ccp - Let a v5 CCP provide the same function as v3") Signed-off-by: Arnd Bergmann --- drivers/crypto/ccp/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig index 2238f77aa248..07af9ece84f9 100644 --- a/drivers/crypto/ccp/Kconfig +++ b/drivers/crypto/ccp/Kconfig @@ -1,6 +1,7 @@ config CRYPTO_DEV_CCP_DD tristate "Cryptographic Coprocessor device driver" depends on CRYPTO_DEV_CCP + depends on !CPU_BIG_ENDIAN || BROKEN default m select HW_RANDOM select DMA_ENGINE -- 2.9.0