From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755247AbdC1KSp (ORCPT ); Tue, 28 Mar 2017 06:18:45 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:64860 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754544AbdC1KSn (ORCPT ); Tue, 28 Mar 2017 06:18:43 -0400 From: Arnd Bergmann To: Mark Yao , David Airlie , Heiko Stuebner Cc: Arnd Bergmann , Sean Paul , Daniel Vetter , Guenter Roeck , Chris Zhong , Jeffy Chen , Tobias Jakobi , Yakir Yang , Stephen Boyd , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/rockchip: fix Kconfig dependencies Date: Tue, 28 Mar 2017 12:16:40 +0200 Message-Id: <20170328101654.73624-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:4dgjW2uvBg6jLU5dtXWs92QZGwHxYMYIe3FwZgjILDZqc8bdjg+ R2qGiVi8fjQpLYJNmMBfKAlTZTonDEDRvMHvPp9ikFPgIhc2dKuxtwMRLDGRqagmYk/JqXG OEF04+YWBj52w9yl6J1QcQt9PfSm9xC/YgSH4BsrG/fn4gdU5mm7a+JMaj0IP3eH6PU0yRg 8H12N+MK76H2jYnF2elBQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:OlIFqyobi9o=:ymkwK3aM+lVn7Lw34KWOJ9 QxfW56jaPtFQPhPO2R9EhAJZ5UWfENl0pX17ElHNAskmWUrrSMnqjII7RTBzPY+UVIojnzUDA CnS72lTnziyd/Yc0tPvFIlKU6i73R5uF8X6y745MfO63lCwkS6JmlhTIflK2nzdb9RuwZBOgA tZb7OGyGFRyWAcCD5oX/d4PPZgcdG1aVYQyEZHuqJ3vEqjSwebJAQoye4mX5giMsZL4xhv/Ea nzRx/dTfhLuCY4As3h2TUWHcqMBwqhzEFjT7GU5+aTbwrCxf8ysmCpAhqnzch0eNx6evt8Kz7 FCahJML6nK4bu+yYinKeP+gqEiarpCU77iw8rk9fKktMldG6ui3mZJJN4PBv+UKHLSijR32DZ nZtymUmaxypQBeTFAoBz4HBEzzwqwo/MdqTg4b2LAcROEw+P6g/c+tdVTEwxVl4RcktTgjzTQ 4OXyIxniHncJilxKiV9lg25U0YG52K2il+S94ko8UOMGtgsbNfsTHdWsnn7P2AAKeN1rli35Q ioroOwami6v6fcQvctU03qoS5Ag6exSXzwEZKS/EvFwG+9X36CE2fbMbOZ70GpuJPxYp4tlTJ JHuyl/bMG9FPOH/bKtutYOO5L9kUFQQdHNuZ/lYAk7gzc8OEmNtvTcrgloz8U4IadIIEXqXlZ iyVSMyFSMflx2AT+ttDvJ2UE/v039y8pGRuOD+v6oXInOehE34WzwbhPXOqjjnSXqaSs= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A bug that I had fixed earlier just came back, with CONFIG_EXTCON=m, the rockchip drm driver will fail to link: drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes': cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x30): undefined reference to `extcon_get_state' cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x6c): undefined reference to `extcon_get_property' drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_check_sink_connection': cdn-dp-core.c:(.text.cdn_dp_check_sink_connection+0x80): undefined reference to `extcon_get_state' drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_enable': cdn-dp-core.c:(.text.cdn_dp_enable+0x748): undefined reference to `extcon_get_property' The problem is that that the sub-drivers are now all linked into the main rockchip drm module, which breaks all the Kconfig dependencies that are specified in the options for those sub-drivers. This clarifies the dependency to ensure that we can only turn on the DP driver when EXTCON is reachable. As the 'select' statements can now cause additional options to become built-in when they should be loadable modules, I'm moving those into the main driver config option. The dependency on DRM_ROCKCHIP can be reduced into a single 'if' statement here for brevity, but this has no functional effect. Fixes: b6705157b2db ("drm/rockchip: add extcon dependency for DP") Fixes: 8820b68bd378 ("drm/rockchip: Refactor the component match logic.") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/rockchip/Kconfig | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig index 50c41c0a50ef..dcc539ba85d6 100644 --- a/drivers/gpu/drm/rockchip/Kconfig +++ b/drivers/gpu/drm/rockchip/Kconfig @@ -5,6 +5,10 @@ config DRM_ROCKCHIP select DRM_KMS_HELPER select DRM_PANEL select VIDEOMODE_HELPERS + select DRM_ANALOGIX_DP if ROCKCHIP_ANALOGIX_DP + select DRM_DW_HDMI if ROCKCHIP_DW_HDMI + select DRM_MIPI_DSI if ROCKCHIP_DW_MIPI_DSI + select SND_SOC_HDMI_CODEC if ROCKCHIP_CDN_DP && SND_SOC help Choose this option if you have a Rockchip soc chipset. This driver provides kernel mode setting and buffer @@ -12,10 +16,10 @@ config DRM_ROCKCHIP 2D or 3D acceleration; acceleration is performed by other IP found on the SoC. +if DRM_ROCKCHIP + config ROCKCHIP_ANALOGIX_DP bool "Rockchip specific extensions for Analogix DP driver" - depends on DRM_ROCKCHIP - select DRM_ANALOGIX_DP help This selects support for Rockchip SoC specific extensions for the Analogix Core DP driver. If you want to enable DP @@ -23,9 +27,7 @@ config ROCKCHIP_ANALOGIX_DP config ROCKCHIP_CDN_DP bool "Rockchip cdn DP" - depends on DRM_ROCKCHIP - depends on EXTCON - select SND_SOC_HDMI_CODEC if SND_SOC + depends on EXTCON=y || (EXTCON=m && DRM_ROCKCHIP=m) help This selects support for Rockchip SoC specific extensions for the cdn DP driver. If you want to enable Dp on @@ -34,8 +36,6 @@ config ROCKCHIP_CDN_DP config ROCKCHIP_DW_HDMI bool "Rockchip specific extensions for Synopsys DW HDMI" - depends on DRM_ROCKCHIP - select DRM_DW_HDMI help This selects support for Rockchip SoC specific extensions for the Synopsys DesignWare HDMI driver. If you want to @@ -44,8 +44,6 @@ config ROCKCHIP_DW_HDMI config ROCKCHIP_DW_MIPI_DSI bool "Rockchip specific extensions for Synopsys DW MIPI DSI" - depends on DRM_ROCKCHIP - select DRM_MIPI_DSI help This selects support for Rockchip SoC specific extensions for the Synopsys DesignWare HDMI driver. If you want to @@ -54,8 +52,9 @@ config ROCKCHIP_DW_MIPI_DSI config ROCKCHIP_INNO_HDMI bool "Rockchip specific extensions for Innosilicon HDMI" - depends on DRM_ROCKCHIP help This selects support for Rockchip SoC specific extensions for the Innosilicon HDMI driver. If you want to enable HDMI on RK3036 based SoC, you should select this option. + +endif -- 2.9.0