From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932320AbdC1LfP (ORCPT ); Tue, 28 Mar 2017 07:35:15 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:59834 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932299AbdC1LfN (ORCPT ); Tue, 28 Mar 2017 07:35:13 -0400 Date: Tue, 28 Mar 2017 13:34:52 +0200 From: Alexandre Belloni To: m18063 Cc: "nicolas.ferre@atmel.com" , "boris.brezillon@free-electrons.com" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "ludovic.desroches@atmel.com" , "cyrille.pitchen@atmel.com" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller Message-ID: <20170328113452.bje7har2ymbr32ad@piout.net> References: <1487838778-13473-1-git-send-email-claudiu.beznea@microchip.com> <20170223084241.6eqm5jxe4t7fpn6a@piout.net> <60c37963-509f-7764-9554-520694294909@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60c37963-509f-7764-9554-520694294909@microchip.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 28/03/2017 at 14:04:25 +0300, m18063 wrote: > >> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi > >> index cd459e8..e88785e 100644 > >> --- a/arch/arm/boot/dts/sama5d2.dtsi > >> +++ b/arch/arm/boot/dts/sama5d2.dtsi > >> @@ -1098,6 +1098,14 @@ > >> status = "disabled"; > >> }; > >> > >> + pwm0: pwm@f802c000 { > >> + compatible = "atmel,sama5d2-pwm"; > > This compatible is not documented and is not used in any driver. Is that > > really working? > > At the moment I send this patch another driver patch was send > to used this device tree bindings and also to document it. > Meanwhile you reviewed also that other patch. > Yes, I received that patch first, without the other ones. You should have put everything in the same series. > Please let me know if you want to send again this DT patch since > I didn't yet receive any inputs its v2. > I'll take it once the pwm patch are taken by Thierry because it is not useful as-is, unless you use: compatible = "atmel,sama5d2-pwm", "atmel,sama5d3-pwm"; -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com