From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756132AbdC1Nd2 (ORCPT ); Tue, 28 Mar 2017 09:33:28 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:32782 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754750AbdC1NdY (ORCPT ); Tue, 28 Mar 2017 09:33:24 -0400 Date: Tue, 28 Mar 2017 19:02:56 +0530 From: simran singhal To: pablo@netfilter.org Cc: outreachy-kernel@googlegroups.com, Jozsef Kadlecsik , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] netfilter: ipset: Use max macro instead of ternary operator Message-ID: <20170328133256.GA24590@singhal-Inspiron-5558> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch replaces ternary operator with macro max as it shorter and thus increases code readability. Macro max return the maximum of the two compared values. Signed-off-by: simran singhal --- net/netfilter/ipset/ip_set_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index 10a3694..248fef7 100644 --- a/net/netfilter/ipset/ip_set_core.c +++ b/net/netfilter/ipset/ip_set_core.c @@ -571,7 +571,7 @@ ip_set_test(ip_set_id_t index, const struct sk_buff *skb, } /* Convert error codes to nomatch */ - return (ret < 0 ? 0 : ret); + return max(0, ret); } EXPORT_SYMBOL_GPL(ip_set_test); -- 2.7.4