From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752814AbdC1Ozi (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Mar 2017 10:55:38 -0400
Received: from foss.arm.com ([217.140.101.70]:50534 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752196AbdC1Ozf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Mar 2017 10:55:35 -0400
Date: Tue, 28 Mar 2017 15:55:23 +0100
From: Liviu Dudau <liviu.dudau@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Brian Starkey <brian.starkey@arm.com>,
        Mali DP Maintainers <malidp@foss.arm.com>,
        David Airlie <airlied@linux.ie>,
        Ville =?utf-8?B?U3lyasOkbMOk?= <ville.syrjala@linux.intel.com>,
        Mihail Atanassov <mihail.atanassov@arm.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Shailendra Verma <shailendra.v@samsung.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: mali-dp: remove unused variable
Message-ID: <20170328145523.GO6816@e110455-lin.cambridge.arm.com>
Mail-Followup-To: Arnd Bergmann <arnd@arndb.de>,
        Brian Starkey <brian.starkey@arm.com>,
        Mali DP Maintainers <malidp@foss.arm.com>,
        David Airlie <airlied@linux.ie>,
        Ville =?utf-8?B?U3lyasOkbMOk?= <ville.syrjala@linux.intel.com>,
        Mihail Atanassov <mihail.atanassov@arm.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Shailendra Verma <shailendra.v@samsung.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20170328140812.1410346-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20170328140812.1410346-1-arnd@arndb.de>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 28, 2017 at 04:07:58PM +0200, Arnd Bergmann wrote:
> The newly introduced function causes a harmless build warning:
> 
> drivers/gpu/drm/arm/malidp_planes.c: In function 'malidp_plane_atomic_print_state':
> drivers/gpu/drm/arm/malidp_planes.c:98:23: error: unused variable 'mp' [-Werror=unused-variable]
> 
> The variable serves no purpose here and can be removed.

Ouch, shame on me for not noticing it :(

Thanks for this!

Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>

> 
> Fixes: 242f43b69c61 ("drm: mali-dp: add atomic_print_state for planes")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/gpu/drm/arm/malidp_planes.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> index 5b0bad87f0b5..afd59e0f7918 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -95,7 +95,6 @@ static void malidp_plane_atomic_print_state(struct drm_printer *p,
>  					    const struct drm_plane_state *state)
>  {
>  	struct malidp_plane_state *ms = to_malidp_plane_state(state);
> -	struct malidp_plane *mp = to_malidp_plane(state->plane);
>  
>  	drm_printf(p, "\trotmem_size=%u\n", ms->rotmem_size);
>  	drm_printf(p, "\tformat_id=%u\n", ms->format);
> -- 
> 2.9.0
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯