From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753663AbdC1RFz (ORCPT ); Tue, 28 Mar 2017 13:05:55 -0400 Received: from mga11.intel.com ([192.55.52.93]:56183 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059AbdC1RFy (ORCPT ); Tue, 28 Mar 2017 13:05:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,237,1486454400"; d="scan'208";a="1113003131" Date: Tue, 28 Mar 2017 10:05:44 -0700 From: Andi Kleen To: Arnaldo Carvalho de Melo Cc: Jin Yao , jolsa@kernel.org, Linux-kernel@vger.kernel.org, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v1] perf report: Drop cycles 0 for LBR print Message-ID: <20170328170544.GF9371@tassilo.jf.intel.com> References: <1489046786-10061-1-git-send-email-yao.jin@linux.intel.com> <20170328153452.GC17135@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170328153452.GC17135@kernel.org> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 28, 2017 at 12:34:52PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Mar 09, 2017 at 04:06:26PM +0800, Jin Yao escreveu: > > For some platforms, for example Broadwell, it doesn't support cycles > > for LBR. But the perf always prints cycles:0, it's not necessary. > > > > The patch refactors the LBR info print code and drops the cycles:0. > > > > For example: perf report --branch-history --no-children --stdio > > Can I get some reviewed-by or acked-by for this patch? Andi? Kan? Reviewed-by: Andi Kleen -Andi