From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755702AbdC1TXd (ORCPT ); Tue, 28 Mar 2017 15:23:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:49230 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755540AbdC1TXb (ORCPT ); Tue, 28 Mar 2017 15:23:31 -0400 Date: Tue, 28 Mar 2017 21:23:03 +0200 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] x86/mce/AMD: Carve out SMCA bank configuration Message-ID: <20170328192303.a732usin3tq6els3@pd.tnic> References: <1490210971-62346-1-git-send-email-Yazen.Ghannam@amd.com> <1490210971-62346-2-git-send-email-Yazen.Ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1490210971-62346-2-git-send-email-Yazen.Ghannam@amd.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 22, 2017 at 02:29:31PM -0500, Yazen Ghannam wrote: > From: Yazen Ghannam > > Scalable MCA systems have a new MCA_CONFIG register that we use to > configure each bank. We currently use this when we set up thresholding. > However, this is logically separate. > > Move setup of MCA_CONFIG into a separate function. > > Signed-off-by: Yazen Ghannam > --- > arch/x86/kernel/cpu/mcheck/mce_amd.c | 48 ++++++++++++++++++++---------------- > 1 file changed, 27 insertions(+), 21 deletions(-) ... > /* cpu init entry point, called from mce.c with preempt off */ > @@ -515,8 +519,10 @@ void mce_amd_feature_init(struct cpuinfo_x86 *c) > int offset = -1; > > for (bank = 0; bank < mca_cfg.banks; ++bank) { > - if (mce_flags.smca) > + if (mce_flags.smca) { > get_smca_bank_info(bank); > + set_smca_config(bank); Or simply bundle those two which do something SMCA-aware per bank into a single: smca_configure(bank); which reads almost like a sentence. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --