From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752447AbdC2CeI (ORCPT ); Tue, 28 Mar 2017 22:34:08 -0400 Received: from mail-ot0-f196.google.com ([74.125.82.196]:36019 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751972AbdC2CeG (ORCPT ); Tue, 28 Mar 2017 22:34:06 -0400 Date: Tue, 28 Mar 2017 21:34:04 -0500 From: Rob Herring To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , Willy Tarreau , Miguel Ojeda Sandonis , Mark Rutland , Ksenija Stanojevic , Arnd Bergmann , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] auxdisplay: hd44780: Fix DT properties to include units of measurement Message-ID: <20170329023404.7p7k4t7ow2evm6my@rob-hp-laptop> References: <1490275537-3769-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490275537-3769-1-git-send-email-geert@linux-m68k.org> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 23, 2017 at 02:25:37PM +0100, Geert Uytterhoeven wrote: > DT properties specifying physical properties should contain appropriate > suffices indicating the units of measurement. > > Hence amend the HD44780 DT bindings to add "chars" suffixes to the > "display-height" and "display-width" properties, and update the driver > to parse them. > > Fixes: dd9502a9e9156dd8 ("dt-bindings: auxdisplay: Add bindings for Hitachi HD44780") > Fixes: d47d88361feea2ce ("auxdisplay: Add HD44780 Character LCD support") > Signed-off-by: Geert Uytterhoeven > --- > Against char-misc-next > > Documentation/devicetree/bindings/auxdisplay/hit,hd44780.txt | 11 ++++++----- > drivers/auxdisplay/hd44780.c | 5 +++-- > 2 files changed, 9 insertions(+), 7 deletions(-) Acked-by: Rob Herring