From: Johannes Thumshirn <jthumshirn@suse.de>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Tejun Heo <tj@kernel.org>,
James Bottomley <jejb@linux.vnet.ibm.com>,
Dan Williams <dan.j.williams@intel.com>,
John Garry <john.garry@huawei.com>,
Jack Wang <jinpu.wang@profitbricks.com>,
Hannes Reinecke <hare@suse.de>,
Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: [PATCH 4/6] scsi: hisi_sas: remove the SAS host after the SCSI host
Date: Wed, 29 Mar 2017 11:41:11 +0200 [thread overview]
Message-ID: <20170329094122.9997-2-jthumshirn@suse.de> (raw)
In-Reply-To: <cover.1490775958.git.jthumshirn@suse.de>
In-Reply-To: <cover.1490775958.git.jthumshirn@suse.de>
After commit bcdde7e ("sysfs: make __sysfs_remove_dir() recursive") changed the
removal path of kernfs to make it recursive we have to remove the SAS host
before the SCSI host or we will see sysfs warnings on not found sysfs groups for
kobjects.
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index 53637a9..34476c2 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -1582,10 +1582,16 @@ int hisi_sas_remove(struct platform_device *pdev)
struct sas_ha_struct *sha = platform_get_drvdata(pdev);
struct hisi_hba *hisi_hba = sha->lldd_ha;
struct Scsi_Host *shost = sha->core.shost;
+ unsigned long flags;
+
+ spin_lock_irqsave(shost->host_lock, flags);
+ if (scsi_host_set_state(shost, SHOST_CANCEL))
+ WARN_ON(scsi_host_set_state(shost, SHOST_CANCEL_RECOVERY));
+ spin_unlock_irqrestore(shost->host_lock, flags);
- scsi_remove_host(sha->core.shost);
sas_unregister_ha(sha);
- sas_remove_host(sha->core.shost);
+ sas_remove_host(shost);
+ scsi_remove_host(shost);
hisi_sas_free(hisi_hba);
kfree(shost);
--
1.8.5.6
next prev parent reply other threads:[~2017-03-29 9:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 9:41 [PATCH 0/2] Fix sysfs recursive removal splats in isci Johannes Thumshirn
2017-03-29 9:41 ` [PATCH 1/2] scsi: sas: flush destruct workqueue on device unregister Johannes Thumshirn
2017-03-29 11:15 ` John Garry
2017-03-29 11:29 ` Johannes Thumshirn
2017-03-29 11:53 ` John Garry
2017-03-29 12:26 ` Johannes Thumshirn
2017-03-29 12:36 ` Jinpu Wang
2017-03-29 12:47 ` Johannes Thumshirn
2017-03-29 12:51 ` Johannes Thumshirn
2017-03-29 9:41 ` [PATCH 2/2] scsi: isci: remove the SAS host after the SCSI host Johannes Thumshirn
2017-03-29 10:17 ` Hannes Reinecke
2017-03-29 9:41 ` [PATCH 3/6] aic94xx: " Johannes Thumshirn
2017-03-29 10:17 ` Hannes Reinecke
2017-03-29 9:41 ` Johannes Thumshirn [this message]
2017-03-29 10:17 ` [PATCH 4/6] scsi: hisi_sas: " Hannes Reinecke
2017-03-29 9:41 ` [PATCH 5/6] mvsas: " Johannes Thumshirn
2017-03-29 10:18 ` Hannes Reinecke
2017-03-29 9:41 ` [PATCH 6/6] scsi: pm8001: " Johannes Thumshirn
2017-03-29 10:18 ` Hannes Reinecke
2017-03-29 10:27 ` Jinpu Wang
2017-03-29 10:30 ` Hannes Reinecke
2017-03-29 11:37 ` [PATCH 0/2] Fix sysfs recursive removal splats in isci James Bottomley
2017-03-29 15:23 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329094122.9997-2-jthumshirn@suse.de \
--to=jthumshirn@suse.de \
--cc=dan.j.williams@intel.com \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jinpu.wang@profitbricks.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®