From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753404AbdC2P3j (ORCPT ); Wed, 29 Mar 2017 11:29:39 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:36357 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979AbdC2P2a (ORCPT ); Wed, 29 Mar 2017 11:28:30 -0400 Date: Wed, 29 Mar 2017 11:28:27 -0400 From: Tejun Heo To: Cao jin Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, cl@linux.com Subject: Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES Message-ID: <20170329152827.GB30385@htj.duckdns.org> References: <1490690107-30009-1-git-send-email-caoj.fnst@cn.fujitsu.com> <20170328160040.GC28157@htj.duckdns.org> <58DB1E19.4020501@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58DB1E19.4020501@cn.fujitsu.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 29, 2017 at 10:38:17AM +0800, Cao jin wrote: > On 03/29/2017 12:00 AM, Tejun Heo wrote: > > On Tue, Mar 28, 2017 at 04:35:07PM +0800, Cao jin wrote: > >> Signed-off-by: Cao jin > > > > I'm not sure. I think I used it during development and it's not like > > it costs anything to keep. > > It easily confusing newbies without any comments for its purpose. percpu variable handling is pretty complex to begin with. I don't buy that an empty default attribute macro adds anything noticeable there. > Temporary using during development seems not good to persist. Could I > know its purpose? I don't remember the exact details but at the same time I don't see the value of the proposed change. We can apply or not apply the patch and either way wouldn't make any noticeable difference. What's the point? Thanks. -- tejun