From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
X86 ML <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
Thomas Garnier <thgarnie@google.com>
Subject: Re: [PATCH v2 1/2] x86/boot/32: Delete cpuinfo_x86::wp_works_ok
Date: Thu, 30 Mar 2017 09:06:57 +0200 [thread overview]
Message-ID: <20170330070657.GA5176@gmail.com> (raw)
In-Reply-To: <CALCETrWOr00ZQuM3XANmJXp-FnfXfu7ZV9vdU8F-04JOC7xAsQ@mail.gmail.com>
* Andy Lutomirski <luto@amacapital.net> wrote:
> On Wed, Mar 29, 2017 at 1:20 PM, Borislav Petkov <bp@alien8.de> wrote:
> > On Wed, Mar 29, 2017 at 09:48:41AM -0700, Andy Lutomirski wrote:
> >> Linux refuses to boot if WP doesn't work okay, so tracking whether
> >> it works serves no purpose. The only use I can see at all for wp_works_ok
> >> is that it lets Xen bypass test_wp_bit(). If this is truly needed,
> >> it could be more cleanly handled using X86_FEATURE_XENPV, but it
> >> looks like Xen can handle test_wp_bit() correctly without special
> >> cases at all.
> >>
> >> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=6415813bae75feba10b8ca3ed6634a72c2a4d313
> >
> > What's up?
> >
>
> Wow, I based on tip/x86/mm per Ingo's request, but maybe that was the
> wrong branch, and apparently Mathias did the same thing in the mean
> time. Whoops. I'll rebase again.
Oops, I didn't realize the duplication either. The splitting up of the patch that
I requested made the merge easier I suspect - albeit that's an unintended side
effect.
Thanks,
Ingo
next prev parent reply other threads:[~2017-03-30 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 16:48 [PATCH v2 0/2] wp_works_ok cleanups again Andy Lutomirski
2017-03-29 16:48 ` [PATCH v2 1/2] x86/boot/32: Delete cpuinfo_x86::wp_works_ok Andy Lutomirski
2017-03-29 20:20 ` Borislav Petkov
2017-03-29 21:05 ` Andy Lutomirski
2017-03-30 7:06 ` Ingo Molnar [this message]
2017-03-29 16:48 ` [PATCH v2 2/2] x86/boot/32: Rewrite test_wp_bit() Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330070657.GA5176@gmail.com \
--to=mingo@kernel.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=thgarnie@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome