From: Piotr Sroka <piotrs@cadence.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Piotr <piotrs@cadence.com>
Subject: RE: [v5 2/4] dt-bindings: mmc: add description of PHY delays for sdhci-cadence
Date: Thu, 30 Mar 2017 12:06:36 +0100 [thread overview]
Message-ID: <201703301106.v2UB6aj4001807@lvloginb.cadence.com> (raw)
In-Reply-To: <CAK7LNAS+=KjuD-31he5fRw=S_t10Uygae7bOWf+uRYVCPeW=5w@mail.gmail.com>
Hi Masahiro
2017-03-22 16:30 Masahiro Yamada <yamada.masahiro@socionext.com>:
> 2017-03-21 23:33 GMT+09:00 Piotr Sroka <piotrs@cadence.com>:
> > DTS properties are used instead of fixed data
> > because PHY settings can be different for different chips/boards.
> > Add description of new DLL PHY delays.
> >
> > Signed-off-by: Piotr Sroka <piotrs@cadence.com>
> > ---
> > Changes for v2:
> > - file was created in v2. It was a part of driver source file patch.
> > - most delays were moved from dts file
> > to data associated with an SoC specific compatible
> > - description of delays was updated to be more clearly
> > ---
> > Changes for v3:
> > - move all delays back to dts because they are also boards dependent
> > - prefix all of the Cadence-specific properties with cdns prefix
> > ---
> > Changes for v4:
> > - change the beginning of the commit subject
> > ---
> > Changes for v5:
> > - change name of property to be consistent with timing modes
> > available in Linux
>
>
> As I gave Reviewed-by in v4 already, this looks good to me.
>
>
> Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
>
> As I said before,
> once you get Reviewed/Acked tags,
> please include them in your later version.
>
Ok. I will remember next time.
--
Best Regards
Piotr Sroka
next prev parent reply other threads:[~2017-03-30 11:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 14:32 [v5 1/4] mmc: sdhci-cadence: Fix writing PHY delay Piotr Sroka
2017-03-21 14:33 ` [v5 2/4] dt-bindings: mmc: add description of PHY delays for sdhci-cadence Piotr Sroka
2017-03-22 7:30 ` Masahiro Yamada
2017-03-30 11:06 ` Piotr Sroka [this message]
2017-03-24 16:26 ` Rob Herring
2017-03-30 19:31 ` Ulf Hansson
2017-03-21 14:33 ` [v5 3/4] mmc: sdhci-cadence: Update PHY delay configuration Piotr Sroka
2017-03-22 7:31 ` Masahiro Yamada
2017-03-29 13:03 ` Adrian Hunter
2017-03-30 19:30 ` Ulf Hansson
2017-03-21 14:33 ` [v5 4/4] mmc: sdhci-cadence: refactor probe function Piotr Sroka
2017-03-22 7:31 ` Masahiro Yamada
2017-03-29 13:03 ` Adrian Hunter
2017-03-30 19:30 ` Ulf Hansson
2017-03-22 7:24 ` [v5 1/4] mmc: sdhci-cadence: Fix writing PHY delay Masahiro Yamada
2017-03-29 13:03 ` Adrian Hunter
2017-03-30 19:30 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201703301106.v2UB6aj4001807@lvloginb.cadence.com \
--to=piotrs@cadence.com \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®