From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934498AbdC3ST4 (ORCPT ); Thu, 30 Mar 2017 14:19:56 -0400 Received: from foss.arm.com ([217.140.101.70]:51198 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933150AbdC3STy (ORCPT ); Thu, 30 Mar 2017 14:19:54 -0400 Date: Thu, 30 Mar 2017 19:19:32 +0100 From: Mark Rutland To: Florian Fainelli Cc: Doug Berger , robh+dt@kernel.org, computersforpeace@gmail.com, gregory.0xf0@gmail.com, bcm-kernel-feedback-list@broadcom.com, linus.walleij@linaro.org, treding@nvidia.com, jonathanh@nvidia.com, olof@lixom.net, mirza.krak@gmail.com, suzuki.poulose@arm.com, bgolaszewski@baylibre.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will.deacon@arm.com Subject: Re: [PATCH v3 0/6] bus: brcmstb_gisb: add support for GISBv7 arbiter Message-ID: <20170330181932.GB8062@leverpostej> References: <20170330002914.7371-1-opendmb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 30, 2017 at 09:33:32AM -0700, Florian Fainelli wrote: > On 03/29/2017 05:29 PM, Doug Berger wrote: > > This patch set contains changes to enable the GISB arbiter driver > > on the latest ARM64 architecture Set-Top Box chips from Broadcom. > > > > Since the ARM64 architecture does not support the hooking of low > > level fault handlers the driver has been adjusted to depend solely > > on GISB interrupts and notify events to provide diagnostic > > messaging. The GISB hardware still triggers bus faults for the > > processor so the default low-level aborts will occur and will be > > handled based on the architecture specific kernel implementation. > > > > While this tends to obsure the GISB error messaging it is still > > reasonable so the same approach is applied to the ARM architecture > > for consistency. > > > > The patches also correct some issues with the existing driver > > and add the new register map for the GISBv7 hardware first > > appearing in the BCM7278 device. > > This all looks great to me, and since there are no more ARM64 > dependencies I can take this via the Broadcom ARM/ARM64 SoC pull requests. > > Mark, are you also happy with this v3? It looks fine by me. Thanks, Mark.