From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934882AbdC3XxL (ORCPT ); Thu, 30 Mar 2017 19:53:11 -0400 Received: from mail.kernel.org ([198.145.29.136]:34578 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934058AbdC3XxK (ORCPT ); Thu, 30 Mar 2017 19:53:10 -0400 Date: Thu, 30 Mar 2017 18:53:06 -0500 From: Bjorn Helgaas To: Manish Jaggi Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Alex Williamson , "Daney, David" , bhelgaas@google.com Subject: Re: [PATCH] pci: quirk cavium: Add device ID range check Message-ID: <20170330235306.GD3912@bhelgaas-glaptop.roam.corp.google.com> References: <43ff1f3f-b098-f25d-b9dc-9e8ef2278110@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43ff1f3f-b098-f25d-b9dc-9e8ef2278110@caviumnetworks.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 17, 2017 at 12:46:29PM +0530, Manish Jaggi wrote: > ACS quirk applies to devices with ID in the range a000-a0XX. > The patch adds a check.This matches on-chip pci devices for > CN81xx/CN83xx/CN88xx > > This patch adds check to > b404bcfbf0 : PCI: Add ACS quirk for all Cavium devices > > Signed-off-by: Manish Jaggi > Acked-by: David Daney Applied with Alex's ack to pci/host-thunder for v4.12, thanks! > --- > drivers/pci/quirks.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index f754453..178242d 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -4094,6 +4094,9 @@ static int pci_quirk_cavium_acs(struct pci_dev *dev, u16 acs_flags) > acs_flags &= ~(PCI_ACS_SV | PCI_ACS_TB | PCI_ACS_RR | > PCI_ACS_CR | PCI_ACS_UF | PCI_ACS_DT); > + if (!((dev->device >= 0xa000) && (dev->device <= 0xa0ff))) > + return -ENOTTY; > + > return acs_flags ? 0 : 1; > } > -- > 2.7.4 > >