From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932558AbdCaEG1 (ORCPT ); Fri, 31 Mar 2017 00:06:27 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:36631 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbdCaEGZ (ORCPT ); Fri, 31 Mar 2017 00:06:25 -0400 Date: Fri, 31 Mar 2017 13:06:17 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Sergey Senozhatsky , kernel-team@lge.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] zram: factor out partial IO routine Message-ID: <20170331040617.GB366@jagdpanzerIV.localdomain> References: <1490773683-10701-1-git-send-email-minchan@kernel.org> <20170330041238.GB513@jagdpanzerIV.localdomain> <20170330233357.GA5807@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170330233357.GA5807@bbox> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On (03/31/17 08:33), Minchan Kim wrote: [..] > > a bigger side effect is that now we double the amount of lines we need > > to change in certain patches and, thus, the amount of work - when we > > add new functionality/fix something in zram_bvec_{write, read} we also > > would need to touch zram_bvec_partial_{write, read}. > > Yes, that is a pain, too. However, I thought it would be more easier > because as-is partial IO routine is more error-prone to me. :) yeah, it is quite tricky and a bit difficult. agree. > > still probably worth it. > > > > Reviewed-by: Sergey Senozhatsky > > Thanks for the review. > so I tried clean-up further to make you happy. :) > > How about this? > It's totally untested and I have no time until Monday next week. > So, please review with having enough time. will take a look :) thanks! -ss