From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933112AbdCaKdG (ORCPT ); Fri, 31 Mar 2017 06:33:06 -0400 Received: from foss.arm.com ([217.140.101.70]:58098 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932733AbdCaKdE (ORCPT ); Fri, 31 Mar 2017 06:33:04 -0400 Date: Fri, 31 Mar 2017 11:32:59 +0100 From: Kim Phillips To: Chewie Lin Cc: greg@kroah.com, forest@alittletooquiet.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Message-Id: <20170331113259.43024d5f495b67c0796a6f7f@arm.com> In-Reply-To: <20170331100112.8106-2-linsh@oregonstate.edu> References: <20170331100112.8106-1-linsh@oregonstate.edu> <20170331100112.8106-2-linsh@oregonstate.edu> Organization: ARM X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 31 Mar 2017 03:01:12 -0700 Chewie Lin wrote: > fix a checkpatch warning: > WARNING: Prefer using "%s", __func__ to embedded function names __func__, so: > - "usb_device_reset fail status=%d\n", status); > + "%s=%d\n", "usb_device_reset fail status", status); "%s=%d\n", __func__ " fail status", status); ? Kim