From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751406AbdDAB7M (ORCPT ); Fri, 31 Mar 2017 21:59:12 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34442 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751297AbdDAB7K (ORCPT ); Fri, 31 Mar 2017 21:59:10 -0400 From: Chewie Lin To: greg@kroah.com, forest@alittletooquiet.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Date: Fri, 31 Mar 2017 18:59:19 -0700 Message-Id: <20170401015919.9181-2-linsh@oregonstate.edu> X-Mailer: git-send-email 2.10.0 In-Reply-To: <20170401015919.9181-1-linsh@oregonstate.edu> References: <20170401015919.9181-1-linsh@oregonstate.edu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace string with formatted arguments in the dev_warn() call. It removes the checkpatch warning: WARNING: Prefer using "%s", __func__ to embedded function names #417: FILE: main_usb.c:417: + "usb_device_reset fail status=%d\n", status); total: 0 errors, 1 warnings, 1058 lines checked And after fix: main_usb.c has no obvious style problems and is ready for submission. Signed-off-by: Chewie Lin --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 9e074e9..2d9e7af 100644 --- a/drivers/staging/vt6656/main_usb.c +++ b/drivers/staging/vt6656/main_usb.c @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) status = usb_reset_device(priv->usb); if (status) dev_warn(&priv->usb->dev, - "usb_device_reset fail status=%d\n", status); + "%s=%d\n", "usb_device_reset fail status", status); } static void vnt_free_int_bufs(struct vnt_private *priv) -- 2.10.0