From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751883AbdDCCnJ (ORCPT ); Sun, 2 Apr 2017 22:43:09 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:41536 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbdDCCnI (ORCPT ); Sun, 2 Apr 2017 22:43:08 -0400 Date: Sun, 02 Apr 2017 19:43:06 -0700 (PDT) Message-Id: <20170402.194306.1830349337879774492.davem@davemloft.net> To: grygorii.strashko@ti.com Cc: netdev@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, ivan.khoronzhuk@linaro.org Subject: Re: [PATCH] net: ethernet: ti: cpsw: wake tx queues on ndo_tx_timeout From: David Miller In-Reply-To: <20170331234123.15607-1-grygorii.strashko@ti.com> References: <20170331234123.15607-1-grygorii.strashko@ti.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 02 Apr 2017 19:01:51 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Grygorii Strashko Date: Fri, 31 Mar 2017 18:41:23 -0500 > In case, if TX watchdog is fired some or all netdev TX queues will be > stopped and as part of recovery it is required not only to drain and > reinitailize CPSW TX channeles, but also wake up stoppted TX queues what > doesn't happen now and netdevice will stop transmiting data until > reopenned. > > Hence, add netif_tx_wake_all_queues() call in .ndo_tx_timeout() to complete > recovery and restore TX path. > > Signed-off-by: Grygorii Strashko Applied, thank you.