From: Andi Shyti <andi.shyti@gmail.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Jaewon Kim <jaewon02.kim@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-kernel@vger.kernel.org, Andi Shyti <andi.shyti@samsung.com>,
Andi Shyti <andi@etezian.org>
Subject: [PATCH v2 1/2] extcon: max77843: improve the code and minimize duplicated lines
Date: Sun, 2 Apr 2017 14:35:41 +0900 [thread overview]
Message-ID: <20170402053542.29570-2-andi@etezian.org> (raw)
In-Reply-To: <20170402053542.29570-1-andi@etezian.org>
From: Andi Shyti <andi.shyti@samsung.com>
Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
---
drivers/extcon/extcon-max77843.c | 33 ++++++++-------------------------
1 file changed, 8 insertions(+), 25 deletions(-)
diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
index 6e722d552cf1..fcdabc4b4025 100644
--- a/drivers/extcon/extcon-max77843.c
+++ b/drivers/extcon/extcon-max77843.c
@@ -264,37 +264,20 @@ static int max77843_muic_get_cable_type(struct max77843_muic_info *info,
chg_type = info->status[MAX77843_MUIC_STATUS2] &
MAX77843_MUIC_STATUS2_CHGTYP_MASK;
- /* Check GROUND accessory with charger cable */
- if (adc == MAX77843_MUIC_ADC_GROUND) {
- if (chg_type == MAX77843_MUIC_CHG_NONE) {
- /*
- * The following state when charger cable is
- * disconnected but the GROUND accessory still
- * connected.
- */
- *attached = false;
- cable_type = info->prev_chg_type;
- info->prev_chg_type = MAX77843_MUIC_CHG_NONE;
- } else {
-
- /*
- * The following state when charger cable is
- * connected on the GROUND accessory.
- */
- *attached = true;
- cable_type = MAX77843_MUIC_CHG_GND;
- info->prev_chg_type = MAX77843_MUIC_CHG_GND;
- }
- break;
- }
-
if (chg_type == MAX77843_MUIC_CHG_NONE) {
*attached = false;
cable_type = info->prev_chg_type;
info->prev_chg_type = MAX77843_MUIC_CHG_NONE;
} else {
*attached = true;
- cable_type = info->prev_chg_type = chg_type;
+ switch (adc) {
+ case MAX77843_MUIC_ADC_GROUND:
+ info->prev_chg_type = MAX77843_MUIC_CHG_GND;
+ break;
+ default:
+ info->prev_chg_type = chg_type;
+ }
+ cable_type = info->prev_chg_type;
}
break;
case MAX77843_CABLE_GROUP_ADC_GND:
--
2.11.0
next prev parent reply other threads:[~2017-04-02 5:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-02 5:35 [PATCH v2 0/2] Add support for USB accessories in the max77843 extcon Andi Shyti
2017-04-02 5:35 ` Andi Shyti [this message]
2017-04-03 7:53 ` [PATCH v2 1/2] extcon: max77843: improve the code and minimize duplicated lines Chanwoo Choi
2017-04-02 5:35 ` [PATCH v2 2/2] extcon: max77843: support USB accessories as external USB hosts Andi Shyti
2017-04-03 8:27 ` Chanwoo Choi
2017-04-03 9:41 ` Andi Shyti
2017-04-03 10:08 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170402053542.29570-2-andi@etezian.org \
--to=andi.shyti@gmail.com \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=cw00.choi@samsung.com \
--cc=jaewon02.kim@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®