From: Greg KH <gregkh@linuxfoundation.org>
To: Daniel Cashman <dan.a.cashman@gmail.com>
Cc: forest@alittletooquiet.net, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6656: Fix spaces, char limit and embedded func name in print.
Date: Sun, 2 Apr 2017 08:02:19 +0200 [thread overview]
Message-ID: <20170402060219.GA7499@kroah.com> (raw)
In-Reply-To: <1491103740-5811-1-git-send-email-dan.a.cashman@gmail.com>
On Sat, Apr 01, 2017 at 08:29:00PM -0700, Daniel Cashman wrote:
> From: Dan Cashman <dan.a.cashman@gmail.com>
>
> Address errors and warning found in rf.c by checkpatch kernel style script.
> Specifically, change spaces to tabs, split function arguments across a new
> line to avoid 80 character limit, and remove use of embedded function name
> in a dev_dbg() call.
That's a lot of different things all in one patch, please break this up
into doing only one type of thing per patch.
thanks,
greg k-h
next prev parent reply other threads:[~2017-04-02 6:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-02 3:29 Daniel Cashman
2017-04-02 6:02 ` Greg KH [this message]
2017-04-02 20:48 ` [Patch v2 0/3] staging: vt6656: Fix checkpatch style violations Daniel Cashman
2017-04-02 20:48 ` [Patch v2 1/3] staging: vt6656: convert spaces to tabs for rf.c Daniel Cashman
2017-04-02 20:48 ` [Patch v2 2/3] staging: vt6656: Replace embedded function name with __func__ in rf.c Daniel Cashman
2017-04-02 20:48 ` [Patch v2 3/3] staging: vt6656: Split arguments to avoid 80-char violation " Daniel Cashman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170402060219.GA7499@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.a.cashman@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome