mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeremy Linton <lintonrjeremy@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: broonie@kernel.org, lgirdwood@gmail.com, puck.chen@hisilicon.com,
	lee.jones@linaro.org, Jeremy Linton <lintonrjeremy@gmail.com>
Subject: [PATCH v2 0/2] Hi655x: mfd/pmic: regulator: Correct dependencies
Date: Mon,  3 Apr 2017 00:28:41 -0500	[thread overview]
Message-ID: <20170403052843.12711-1-lintonrjeremy@gmail.com> (raw)

In an environment where the hi655x pmic is being built as a 
standalone module, it fails to automatically load resulting
in boot failures, machine hangs, etc. First we correct this
by setting an appropriate module dependency. Then we bump the
module use count on the mfd/pmic driver so that it cannot be
unloaded when in use. This avoids an unload warning and
crashes like:

 Unable to handle kernel paging request at virtual address ffff800078fc5c78
 pgd = ffff00000a150000
 *pgd=000000007ffc0003, *pud=000000007ffc0003, *pmd=00e8000060000711
 Internal error: Oops: 8600000e [#1] SMP
 ...
 [<ffff800078fc5c78>] 0xffff800078fc5c78
 [<ffff0000086248f8>] regulator_set_voltage_sel_regmap+0x50/0x98
 [<ffff00000861e830>] _regulator_do_set_voltage+0x4c8/0x7c0
 [<ffff000008620804>] regulator_set_voltage_unlocked+0xc4/0x258
 [<ffff0000086209d4>] regulator_set_voltage+0x3c/0x70
 [<ffff000000af1b30>] mmc_regulator_set_ocr+0x48/0x100 [mmc_core]
 [<ffff000000c93da8>] dw_mci_set_ios+0x1e8/0x280 [dw_mmc]
 [<ffff000000af483c>] mmc_set_initial_state+0x84/0xf8 [mmc_core]
 [<ffff000000af490c>] mmc_power_up.part.13+0x5c/0x1f8 [mmc_core]
 [<ffff000000af5c20>] mmc_rescan+0x270/0x3b0 [mmc_core]
 [<ffff0000080f3a14>] process_one_work+0x264/0x7c0
 [<ffff0000080f3fc4>] worker_thread+0x54/0x430
 [<ffff0000080fc5dc>] kthread+0x104/0x130
 [<ffff000008083380>] ret_from_fork+0x10/0x50

V1->V2:
  Change from a module post call to a module_device_table.

Jeremy Linton (2):
  regulator: hi655x: Describe consumed platform device
  regulator: hi655x: Bump parent pmic module use count

 drivers/regulator/hi655x-regulator.c | 33 +++++++++++++++++++++++++++++++--
 1 file changed, 31 insertions(+), 2 deletions(-)

-- 
2.10.2

             reply	other threads:[~2017-04-03  5:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-03  5:28 Jeremy Linton [this message]
2017-04-03  5:28 ` [PATCH v2 1/2] regulator: hi655x: Describe consumed platform device Jeremy Linton
2017-04-04 12:23   ` Applied "regulator: hi655x: Describe consumed platform device" to the regulator tree Mark Brown
2017-04-03  5:28 ` [PATCH v2 2/2] regulator: hi655x: Bump parent pmic module use count Jeremy Linton
2017-04-03 17:19   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170403052843.12711-1-lintonrjeremy@gmail.com \
    --to=lintonrjeremy@gmail.com \
    --cc=broonie@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=puck.chen@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®