From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752873AbdDCL0u (ORCPT ); Mon, 3 Apr 2017 07:26:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46394 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752351AbdDCL0r (ORCPT ); Mon, 3 Apr 2017 07:26:47 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 772497E9C5 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 772497E9C5 From: Hans de Goede To: MyungJoo Ham , Chanwoo Choi Cc: Hans de Goede , Takashi Iwai , linux-kernel@vger.kernel.org Subject: [PATCH 1/3] extcon: intel-cht-wc: Make error messages consistent Date: Mon, 3 Apr 2017 13:26:28 +0200 Message-Id: <20170403112630.30625-1-hdegoede@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 03 Apr 2017 11:26:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Before this commit the error messages were a mix of "Failed to ..." and "Error ...ing ...". This commit makes all the error messages consistently use "Error ...ing". Signed-off-by: Hans de Goede --- drivers/extcon/extcon-intel-cht-wc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/extcon/extcon-intel-cht-wc.c b/drivers/extcon/extcon-intel-cht-wc.c index 0a05cc3..f1c43af 100644 --- a/drivers/extcon/extcon-intel-cht-wc.c +++ b/drivers/extcon/extcon-intel-cht-wc.c @@ -252,7 +252,7 @@ static int cht_wc_extcon_sw_control(struct cht_wc_extcon_data *ext, bool enable) val = enable ? mask : 0; ret = regmap_update_bits(ext->regmap, CHT_WC_CHGRCTRL0, mask, val); if (ret) - dev_err(ext->dev, "Failed setting sw control: %d\n", ret); + dev_err(ext->dev, "Error setting sw control: %d\n", ret); return ret; } @@ -288,7 +288,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev) /* Register extcon device */ ret = devm_extcon_dev_register(ext->dev, ext->edev); if (ret) { - dev_err(ext->dev, "Failed to register extcon device\n"); + dev_err(ext->dev, "Error registering extcon device: %d\n", ret); goto disable_sw_control; } @@ -301,7 +301,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev) ret = devm_request_threaded_irq(ext->dev, irq, NULL, cht_wc_extcon_isr, IRQF_ONESHOT, pdev->name, ext); if (ret) { - dev_err(ext->dev, "Failed to request interrupt\n"); + dev_err(ext->dev, "Error requesting interrupt: %d\n", ret); goto disable_sw_control; } @@ -310,7 +310,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev) (int)~(CHT_WC_PWRSRC_VBUS | CHT_WC_PWRSRC_ID_GND | CHT_WC_PWRSRC_ID_FLOAT)); if (ret) { - dev_err(ext->dev, "Failed to write the irq-mask: %d\n", ret); + dev_err(ext->dev, "Error writing irq-mask: %d\n", ret); goto disable_sw_control; } -- 2.9.3