From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
dmitry.torokhov@gmail.com, nicolas.ferre@microchip.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] dt-bindings: input: Add Atmel PTC subsystem bindings
Date: Mon, 3 Apr 2017 17:59:09 +0200 [thread overview]
Message-ID: <20170403155909.wbo4f4x3agqtim5c@piout.net> (raw)
In-Reply-To: <20170331152250.12758-5-ludovic.desroches@microchip.com>
I think this patch should be first so you add the bindings before the
driver.
On 31/03/2017 at 17:22:50 +0200, Ludovic Desroches wrote:
> Add description of the Atmel PTC subsystem bindings.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> ---
> .../devicetree/bindings/input/atmel,ptc.txt | 67 ++++++++++++++++++++++
> 1 file changed, 67 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/atmel,ptc.txt
>
> diff --git a/Documentation/devicetree/bindings/input/atmel,ptc.txt b/Documentation/devicetree/bindings/input/atmel,ptc.txt
> new file mode 100644
> index 0000000..a183fd5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/atmel,ptc.txt
> @@ -0,0 +1,67 @@
> +Atmel PTC Subsystem
> +
> +The Atmel Peripheral Touch Controller subsystem offers built-in hardware
> +for capacitive touch measurement on sensors that function as buttons, sliders
> +and wheels.
> +
> +1) PTC Subsystem node
> +
> +Required properties:
> +- compatible: Must be "atmel,sama5d2-ptc"
> +- reg: Address, length of the shared memory and ppp registers location
> + and length.
> +- clocks: Phandlers to the clocks.
> +- clock-names: Must be "ptc_clk", "ptc_int_osc", "slow_clk".
> +- #address-cells: Must be one. The cell is the button or scroller id.
> +- #size-cells: Must be zero.
> +
> +Example:
> + ptc@fc060000 {
> + compatible = "atmel,sama5d2-ptc";
> + reg = <0x00800000 0x10000
> + 0xfc060000 0xcf>;
> + interrupts = <58 IRQ_TYPE_LEVEL_HIGH 7>;
> + clocks = <&ptc_clk>, <&main>, <&clk32k>;
> + clock-names = "ptc_clk", "ptc_int_osc", "slow_clk";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + [ child node definitions... ]
> + };
> +
> +2) Scroller / buttons subnodes
> +
> +Subnodes describe the kind of sensors the customer want to use. They have to be
> +named according to their function: button, slider or wheel.
> +
> +2.1) Scroller subnodes
> +
> +Required properties:
> +- reg: Id of the scroller, each id must be different.
> +
> +Example:
> + slider@0 {
> + reg = <0>;
> + };
> +
> + wheel@1 {
> + reg = <1>;
> + };
> +
> +2.2) Button subnodes
> +
> +Required properties:
> +- reg: Id of node used for the button, each id must be
> + different.
> +- linux,keycode: Key code of the button.
> +
> +Example:
> + button@8 {
> + reg = <8>;
> + linux,keycode = <2>;
> + };
> +
> + button@9 {
> + reg = <9>;
> + linux,keycode = <3>;
> + };
> --
> 2.9.0
>
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-04-03 15:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 15:22 [PATCH 0/4] Introduce the Atmel PTC subsystem Ludovic Desroches
2017-03-31 15:22 ` [PATCH 1/4] input: misc: introduce Atmel PTC driver Ludovic Desroches
2017-04-03 15:58 ` Alexandre Belloni
2017-04-04 6:47 ` Ludovic Desroches
2017-03-31 15:22 ` [PATCH 2/4] ARM: dts: at91: sama5d2: add PTC subsystem device Ludovic Desroches
2017-03-31 15:22 ` [PATCH 3/4] MAINTAINERS: add Atmel PTC entries Ludovic Desroches
2017-03-31 15:22 ` [PATCH 4/4] dt-bindings: input: Add Atmel PTC subsystem bindings Ludovic Desroches
2017-04-03 15:59 ` Alexandre Belloni [this message]
2017-04-03 16:50 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403155909.wbo4f4x3agqtim5c@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®