From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754046AbdDCQwn (ORCPT ); Mon, 3 Apr 2017 12:52:43 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:33997 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751803AbdDCQwl (ORCPT ); Mon, 3 Apr 2017 12:52:41 -0400 Date: Mon, 3 Apr 2017 11:52:39 -0500 From: Rob Herring To: Helmut Klein Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] dt-binding: meson_uart: add documentation for the UARTs of amlogic Message-ID: <20170403165239.2k2sajeu2vout7hf@rob-hp-laptop> References: <20170331165437.26227-1-hgkr.klein@gmail.com> <20170331165437.26227-3-hgkr.klein@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170331165437.26227-3-hgkr.klein@gmail.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 31, 2017 at 06:54:35PM +0200, Helmut Klein wrote: > Add the documentation for the device tree binding of meson_uart > > Signed-off-by: Helmut Klein > --- > .../bindings/serial/amlogic,meson_uart.txt | 30 ++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt > > diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt b/Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt > new file mode 100644 > index 000000000000..8250a191c2fc > --- /dev/null > +++ b/Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt > @@ -0,0 +1,30 @@ > +* Amlogic Meson UART, used in multiple SoCs (e.g. S905, s905X, ...) > + > +Required properties: > +- compatible : "amlogic,meson-uart" Should have SoC specific compatible strings in addition. > +- reg : offset and length of the register set for the device. > +- interrupts : device interrupt > +- clocks : a list of phandle + clock-specifier pairs, one for each > + entry in clock names. > +- clocks-names : contains: > + * "xtal" for the baud rate clock > + * "core" for the core clock of none AO UARTs (optional) > + > +e.g. > +uart_A: serial@84c0 { > + compatible = "amlogic,meson-uart"; > + reg = <0x0 0x84c0 0x0 0x14>; > + pinctrl-0 = <&uart_a_pins &uart_a_cts_rts_pins>; > + interrupts = ; > + clocks = <&xtal>, <&clkc CLKID_UART0>; > + clock-names = "xtal", "core"; > + status = "ok"; Drop status from examples. > +}; > + > +Note: Each port should have an alias correctly numbered in "aliases" node. True for pretty much any uart, so you can drop this. > + > +e.g. > +aliases { > + serial0 = &uart_AO; > + serial1 = &uart_A; > +}; > -- > 2.11.0 >