From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752379AbdDDGs0 (ORCPT ); Tue, 4 Apr 2017 02:48:26 -0400 Received: from esa4.microchip.iphmx.com ([68.232.154.123]:15962 "EHLO esa4.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbdDDGr1 (ORCPT ); Tue, 4 Apr 2017 02:47:27 -0400 X-IronPort-AV: E=Sophos;i="5.36,274,1486450800"; d="scan'208";a="935452" Date: Tue, 4 Apr 2017 08:47:16 +0200 From: Ludovic Desroches To: Alexandre Belloni CC: Ludovic Desroches , , , , , , , Ludovic Desroches Subject: Re: [PATCH 1/4] input: misc: introduce Atmel PTC driver Message-ID: <20170404064716.6uibtyin73otpqsd@rfolt0960.corp.atmel.com> Mail-Followup-To: Alexandre Belloni , linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, dmitry.torokhov@gmail.com, nicolas.ferre@microchip.com, linux-kernel@vger.kernel.org, Ludovic Desroches References: <20170331152250.12758-1-ludovic.desroches@microchip.com> <20170331152250.12758-2-ludovic.desroches@microchip.com> <20170403155840.vln4wg56iunrmdcw@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170403155840.vln4wg56iunrmdcw@piout.net> User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 03, 2017 at 05:58:40PM +0200, Alexandre Belloni wrote: > On 31/03/2017 at 17:22:47 +0200, Ludovic Desroches wrote: > > From: Ludovic Desroches > > I think you probably want to switch to your microchip email. > > Also, this requires a proper commit message. I'll fix this, I'll take the cover letter as commit message and update the mail address. > > > > > Signed-off-by: Ludovic Desroches > > +struct atmel_ptc { > > + void __iomem *ppp_regs; > > + void __iomem *firmware; > > + int irq; > > + uint8_t imr; > > + volatile struct atmel_qtm_mailbox __iomem *qtm_mb; > > + struct clk *clk_per; > > + struct clk *clk_int_osc; > > + struct clk *clk_slow; > > + struct device *dev; > > + struct completion ppp_ack; > > + unsigned int button_keycode[ATMEL_PTC_MAX_NODES]; > > + struct input_dev *buttons_input; > > + struct input_dev *scroller_input[ATMEL_PTC_MAX_SCROLLERS]; > > + bool buttons_registered; > > + bool scroller_registered[ATMEL_PTC_MAX_SCROLLERS]; > > + uint32_t button_event[ATMEL_PTC_MAX_NODES/32]; > > + uint32_t button_state[ATMEL_PTC_MAX_NODES/32]; > > + uint32_t scroller_event; > > + uint32_t scroller_state; > > You should use u8, u16 and u32 instead of uint8_t, uint16_t and > uint32_t. Do you want me to also change the atmel_ptc.h header and use __u8 and co? Since I share it with bare metal software, uintxx_t was more convenient. > > > diff --git a/include/uapi/linux/atmel_ptc.h b/include/uapi/linux/atmel_ptc.h > > new file mode 100644 > > index 0000000..d15c4df > > --- /dev/null > > +++ b/include/uapi/linux/atmel_ptc.h > > > Is there any sample application showing how to configure the PTC? > Tooling and examples are in development. The tool allows you to produce the atmel_ptc.conf binary or to tweak the configuration in real time with commands such as: - set node_group_conf count 10 - get node_config 0 - dump_conf - export_conf atmel_ptc.conf The application only use input devices. Ludovic