From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754116AbdDDMCq (ORCPT ); Tue, 4 Apr 2017 08:02:46 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:51981 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753613AbdDDMCp (ORCPT ); Tue, 4 Apr 2017 08:02:45 -0400 Date: Tue, 4 Apr 2017 05:02:44 -0700 From: Matthew Wilcox To: Anshuman Khandual Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, vbabka@suse.cz, mgorman@suse.de, bsingharora@gmail.com, akpm@linux-foundation.org Subject: Re: [PATCH] mm/mmap: Replace SHM_HUGE_MASK with MAP_HUGE_MASK inside mmap_pgoff Message-ID: <20170404120244.GI30811@bombadil.infradead.org> References: <20170404045635.616-1-khandual@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170404045635.616-1-khandual@linux.vnet.ibm.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 04, 2017 at 10:26:35AM +0530, Anshuman Khandual wrote: > The commit 091d0d55b286 ("shm: fix null pointer deref when userspace > specifies invalid hugepage size") had replaced MAP_HUGE_MASK with > SHM_HUGE_MASK. Though both of them contain the same numeric value of > 0x3f, MAP_HUGE_MASK flag sounds more appropriate than the other one > in the context. Hence change it back. > > Acked-by: Balbir Singh > Acked-by: Michal Hocko > Signed-off-by: Anshuman Khandual Reviewed-by: Matthew Wilcox We had a more extensive version of this last week ... https://lkml.org/lkml/2017/3/28/1005 I'm fine with this minor fix going in by itself.