From: Michal Hocko <mhocko@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
arve@android.com, riandrews@android.com,
Todd Kjos <tkjos@google.com>,
devel@driverdev.osuosl.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [RFC PATCH] binder: Don't require the binder lock when killed in binder_thread_read()
Date: Tue, 4 Apr 2017 17:29:21 +0200 [thread overview]
Message-ID: <20170404152921.GO15132@dhcp22.suse.cz> (raw)
In-Reply-To: <CAD=FV=XnWBX78W6NH_s1zfmvtpNyF=_82az2oUgfX70-CR1HeA@mail.gmail.com>
On Tue 04-04-17 08:10:03, Doug Anderson wrote:
> Hi,
>
> On Tue, Apr 4, 2017 at 12:40 AM, Michal Hocko <mhocko@kernel.org> wrote:
[...]
> > So the primary question is what are you trying to achieve?
>
> Ideally it would be nice to bring back patches to make the OOM
> handling lockup free. However, presuming that's not feasible then at
> least it would be nice if we could get some minimal set of patches
> that:
>
> - Isn't too scary to backport.
> - Handles the low hanging fruit.
> - Is fairly self contained.
oom_reaper as introduced by aac4536355496 and 4 follow up patches should
be a good yet not too scary to start.
> 1. It would be nice if other users of linuxstable could benefit.
well most of the oom fixes are rather subtle and it took quite some time
to do the properly so I am not really sure we want to take risk. I would
rather handle those issues and backport specific fixes for the issue.
> 2. I know the above patches are not as ideal as the work that has
> happened upstream, so of course I'd prefer to get the upstream
> solution.
>
> 3. I always appreciate being closer to the upstream solution which
> means we get more people looking at the code and more people testing
> the code.
I can hardly help you more than offer to use the upstream code. I fully
realize that this is hard and I am facing similar issues with enterprise
kernel @Suse but so far I have seen OOMs behaving mostly OK except for
extreme cases which usually do not happen enough to take the risk and
backport non-trivial changes to the stable trees.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2017-04-04 15:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 17:53 Douglas Anderson
2017-03-31 19:29 ` Greg KH
2017-03-31 21:00 ` Doug Anderson
2017-04-01 6:48 ` Greg KH
2017-04-02 2:34 ` Doug Anderson
2017-04-03 13:25 ` Greg KH
2017-04-03 18:09 ` Doug Anderson
2017-04-04 7:40 ` Michal Hocko
2017-04-04 15:10 ` Doug Anderson
2017-04-04 15:29 ` Michal Hocko [this message]
2017-04-03 13:47 ` peter enderborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170404152921.GO15132@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
--cc=stable@vger.kernel.org \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®