From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Oder Chiou <oder_chiou@realtek.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Bard Liao <bardliao@realtek.com>
Subject: [PATCH 1/6] ASoc: rt5645: Add OF device ID table
Date: Tue, 4 Apr 2017 15:26:25 -0400 [thread overview]
Message-ID: <20170404192630.11408-2-javier@osg.samsung.com> (raw)
In-Reply-To: <20170404192630.11408-1-javier@osg.samsung.com>
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.
Before this patch:
$ modinfo sound/soc/codecs/snd-soc-rt5645.ko | grep alias
alias: acpi*:10EC3270:*
alias: acpi*:10EC5640:*
alias: acpi*:10EC5650:*
alias: acpi*:10EC5648:*
alias: acpi*:10EC5645:*
alias: i2c:rt5650
alias: i2c:rt5645
After this patch:
$ modinfo sound/soc/codecs/snd-soc-rt5645.ko | grep alias
alias: of:N*T*Crealtek,rt5650C*
alias: of:N*T*Crealtek,rt5650
alias: of:N*T*Crealtek,rt5645C*
alias: of:N*T*Crealtek,rt5645
alias: acpi*:10EC3270:*
alias: acpi*:10EC5640:*
alias: acpi*:10EC5650:*
alias: acpi*:10EC5648:*
alias: acpi*:10EC5645:*
alias: i2c:rt5650
alias: i2c:rt5645
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
sound/soc/codecs/rt5645.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c
index e149f3ce5401..87844a45886a 100644
--- a/sound/soc/codecs/rt5645.c
+++ b/sound/soc/codecs/rt5645.c
@@ -3542,6 +3542,15 @@ static const struct i2c_device_id rt5645_i2c_id[] = {
};
MODULE_DEVICE_TABLE(i2c, rt5645_i2c_id);
+#ifdef CONFIG_OF
+static const struct of_device_id rt5645_of_match[] = {
+ { .compatible = "realtek,rt5645", },
+ { .compatible = "realtek,rt5650", },
+ { }
+};
+MODULE_DEVICE_TABLE(of, rt5645_of_match);
+#endif
+
#ifdef CONFIG_ACPI
static const struct acpi_device_id rt5645_acpi_match[] = {
{ "10EC5645", 0 },
@@ -3912,6 +3921,7 @@ static void rt5645_i2c_shutdown(struct i2c_client *i2c)
static struct i2c_driver rt5645_i2c_driver = {
.driver = {
.name = "rt5645",
+ .of_match_table = of_match_ptr(rt5645_of_match),
.acpi_match_table = ACPI_PTR(rt5645_acpi_match),
},
.probe = rt5645_i2c_probe,
--
2.9.3
next prev parent reply other threads:[~2017-04-04 19:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 19:26 [PATCH 0/6] ASoC: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas
2017-04-04 19:26 ` Javier Martinez Canillas [this message]
2017-04-05 17:30 ` Applied "ASoc: rt5645: Add OF device ID table" to the asoc tree Mark Brown
2017-04-04 19:26 ` [PATCH 2/6] ASoC: ssm4567: Add OF device ID table Javier Martinez Canillas
2017-04-05 17:30 ` Applied "ASoC: ssm4567: Add OF device ID table" to the asoc tree Mark Brown
2017-04-04 19:26 ` [PATCH 3/6] ASoC: sta529: Add OF device ID table Javier Martinez Canillas
2017-04-05 17:30 ` Applied "ASoC: sta529: Add OF device ID table" to the asoc tree Mark Brown
2017-04-04 19:26 ` [PATCH 4/6] ASoC: uda1380: Add OF device ID table Javier Martinez Canillas
2017-04-05 17:30 ` Applied "ASoC: uda1380: Add OF device ID table" to the asoc tree Mark Brown
2017-04-04 19:26 ` [PATCH 5/6] ASoC: wm8978: Add OF device ID table Javier Martinez Canillas
2017-04-05 8:51 ` Charles Keepax
2017-04-05 17:30 ` Applied "ASoC: wm8978: Add OF device ID table" to the asoc tree Mark Brown
2017-04-04 19:26 ` [PATCH 6/6] ASoC: rt5677: Add OF device ID table Javier Martinez Canillas
2017-04-05 17:30 ` Applied "ASoC: rt5677: Add OF device ID table" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170404192630.11408-2-javier@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®