From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753735AbdDEOTt (ORCPT <rfc822;w@1wt.eu>);
        Wed, 5 Apr 2017 10:19:49 -0400
Received: from mail.skyhub.de ([5.9.137.197]:50558 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753091AbdDEOTM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 5 Apr 2017 10:19:12 -0400
Date: Wed, 5 Apr 2017 16:19:02 +0200
From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <Yazen.Ghannam@amd.com>
Cc: linux-edac@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
        x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] x86/mce/AMD: Carve out SMCA bank configuration
Message-ID: <20170405141902.6dnh2gzpt7k35e4l@pd.tnic>
References: <1491326672-48298-1-git-send-email-Yazen.Ghannam@amd.com>
 <1491326672-48298-2-git-send-email-Yazen.Ghannam@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1491326672-48298-2-git-send-email-Yazen.Ghannam@amd.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 04, 2017 at 12:24:32PM -0500, Yazen Ghannam wrote:
> From: Yazen Ghannam <yazen.ghannam@amd.com>
> 
> Scalable MCA systems have a new MCA_CONFIG register that we use to
> configure each bank. We currently use this when we set up thresholding.
> However, this is logically separate.
> 
> Group all SMCA-related initialization into a single, separate function.
> This includes setting MCA_CONFIG and gathering SMCA bank info.
> 
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> ---
> Link:
> https://lkml.kernel.org/r/1490210971-62346-2-git-send-email-Yazen.Ghannam@amd.com
> 
> v1->v2:
> - Merge get_smca_bank_info() and set_smca_config() into smca_configure().
> 
>  arch/x86/kernel/cpu/mcheck/mce_amd.c | 74 ++++++++++++++++++------------------
>  1 file changed, 37 insertions(+), 37 deletions(-)

...

> @@ -516,7 +516,7 @@ void mce_amd_feature_init(struct cpuinfo_x86 *c)
>  
>  	for (bank = 0; bank < mca_cfg.banks; ++bank) {
>  		if (mce_flags.smca)
> -			get_smca_bank_info(bank);
> +			smca_configure(bank);

Pass in cpu from above:

			smca_configure(bank, cpu);


>  
>  		for (block = 0; block < NR_BLOCKS; ++block) {
>  			address = get_block_address(cpu, address, low, high, bank, block);
> -- 

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.